Comment 4 for bug 1548902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/liberty)

Reviewed: https://review.openstack.org/283708
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=4f41717204dea123fac1050956cd87dea261794e
Submitter: Jenkins
Branch: stable/liberty

commit 4f41717204dea123fac1050956cd87dea261794e
Author: Brianna Poulos <email address hidden>
Date: Fri Jan 22 15:13:35 2016 -0500

    Remove unneeded glance unit test assert calls

    The glance_store library now accepts a verifier object for use with
    verifying signatures, as a result of a recently merged patch [1].
    There are some glance unit tests that do not expect this verifier
    object to be passed to the add method of glance_store, and will
    therefore fail with a new release of the glance_store library.

    This patch removes the assert lines for the tests that will fail,
    since it is not necessary for glance to test glance_store in that
    way at the glance level.

    [1] https://review.openstack.org/#/c/183110/

    Change-Id: I404fbc40dafa159a63a6dfee563f05ee80c073dc
    Partial-Bug: #1516031
    (cherry picked from commit eab1567d48a18fa968c7b66c3641dd037da1f84e)

    -- squashed with another change to get liberty working --

    Remove glance_store specific unit tests

    TestStoreAddToBackend contains a set of tests that should belong to
    the glance_store. Recently, these tests were about to break
    glance as they mocked internal methods. Those mocks were
    removed in commit eab1567d48a18fa968c7b66c3641dd037da1f84e.

    The tests are added back to glance_store in
    change https://review.openstack.org/#/c/273786.

    Conflicts:
            glance/tests/unit/test_store_image.py

    Closes-Bug: #1548902

    Depends-On: I688629d37e9146aef33fbc9bb6fd8780521e06ab
    Change-Id: Ic67826a4d02cb30cc429a3d4abc46d6ca96f31ad
    (cherry picked from commit 1ebbfd3dc1694dc4f26e763da9eee833bb5d2545)