While attempting to improve help text for configuration option
"swift_store_config_file", None is incorrectly listed as a
possible value. None is incorrect because a configuration option
can either be set or not. It can't be set to None. When no value
is set for a configuration option, it is inherently parsed as None
by oslo.config. Hence, there is no need to specify None as a
possible value.
Also, the configuration option swift_store_config_file is marked as
secret. Although the file pointed by this path can contain
credentials, the path itself need not be marked secret. This in fact
may make debugging harder if the file path is not logged clearly.
Reviewed: https:/ /review. openstack. org/355622 /git.openstack. org/cgit/ openstack/ glance_ store/commit/ ?id=0ec9da6ce5e 30848e6b060c98d 91e072cbe4caf5
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0ec9da6ce5e3084 8e6b060c98d91e0 72cbe4caf5
Author: Hemanth Makkapati <email address hidden>
Date: Mon Aug 15 14:36:21 2016 -0500
Fix help text of swift_store_ config_ file
While attempting to improve help text for configuration option store_config_ file", None is incorrectly listed as a
"swift_
possible value. None is incorrect because a configuration option
can either be set or not. It can't be set to None. When no value
is set for a configuration option, it is inherently parsed as None
by oslo.config. Hence, there is no need to specify None as a
possible value.
Also, the configuration option swift_store_ config_ file is marked as
secret. Although the file pointed by this path can contain
credentials, the path itself need not be marked secret. This in fact
may make debugging harder if the file path is not logged clearly.
Change-Id: If4fa246d642098 e96093cb6be92b8 cd9f4350268
Partial-Bug: #1570946