Overweight can't eat sandvich very sad

[L]

Me and psycho thinks maybe a class check isn't working properly or something. So basically you can't right click and eat sandvich, even after a new round starts, death, or class switch

[MedO (smaxein)]

I looked for a bit, but didn't find the cause yet. More details would be helpful in nailing down the cause, e.g. what game mode / server it happened on, if it also happens when you host yourself, and if other special stuff (building as engineer) doesn't work either.

[L (sharkbait261)]

Haven't seeing it occur again, granted haven't been using overweight; will do more testing later.

IIRC it was arena and I was not the host and I do believe a game mode changed allowed me once again to eat.

[MedO (smaxein)]

I checked the code path again and found a possible cause: humiliation on the server is not properly reset to false after a round end, but it is on the clients. I don't know yet how this happens or if it's really the cause, but analysing the code thoroughly left that as the only reasonable soure of the problem, and simulating the situation leads to the described behaviour.

[Chris P. Bacon (sfraser0204)]

I have confirmed humiliation is being reset server and client side when a new arena round starts. I can't recreate this bug. Any more info?

[L (sharkbait261)]

No more info than that seems to happen at random

[MedO (smaxein)]

I managed to reproduce it: Humiliation isn't reset server-side when the map is changed. So, if the game mode changes from Arena to something else those players who were humiliated on round end won't be able to omnomnom. Resetting humiliation for all players when loading a new map will probably fix this, but IMO we could put a bit more thought into this.

The current system is really not good, it relies on client side checks for humiliation and stores the humiliated flag for every player, which is unneccessary. Maybe we should add Team objects and make humiliated a property of those instead.