Thanks for the patch, Eivind. Unfortunately, at first glance your changes to the Scheme API are obviously bogus, and I have to NACK this patch for now.
- You must update the testsuite (probably libgeda/scheme/unit-tests/t0203-page-string-syntax.scm).
- You must update the documentation (docs/scheme-api/geda-scheme.texi).
- You must use an appropriate exception key symbol (i.e. not 'object-state').
- You must use a '~a' or '~s' format specifier (Scheme does not use '%' as the format escape symbol; read the Guile manual entry for 'simple-format').
I also suggest that you split the patch into two: one which updates the libgeda core, and one which updates the Scheme API with the changes I've requested above.
These were the issues that immediately leapt out at me; I haven't had time to look through the rest of the patch yet, but I'll try to find time to do so later this week.
Thanks for the patch, Eivind. Unfortunately, at first glance your changes to the Scheme API are obviously bogus, and I have to NACK this patch for now.
- You must update the testsuite (probably libgeda/ scheme/ unit-tests/ t0203-page- string- syntax. scm). api/geda- scheme. texi).
- You must update the documentation (docs/scheme-
- You must use an appropriate exception key symbol (i.e. not 'object-state').
- You must use a '~a' or '~s' format specifier (Scheme does not use '%' as the format escape symbol; read the Guile manual entry for 'simple-format').
I also suggest that you split the patch into two: one which updates the libgeda core, and one which updates the Scheme API with the changes I've requested above.
These were the issues that immediately leapt out at me; I haven't had time to look through the rest of the patch yet, but I'll try to find time to do so later this week.