gEDA

  1. Bug #1849621
  2. Comment #2

Comment 2 for bug 1849621

Revision history for this message
Roland Lutz (rlutz) wrote :

Thank you.

It would be helpful if you could generate future diffs with `git format-patch', e.g.:

  git format-patch HEAD^

This way, the diff is already in the format `git am' expects.

Also, it is common to reference the bug number with "Closes-bug: lp-1849621" at the end of the commit message, separated by an empty line (see commit be34592 for an example).

Which warning options do you use, BTW? I can't seem to get these warnings even with `-Wall -Wextra'.

fixed in 9ccf689d4d2ef5f164f650a4e1ff360cb1a80e1e
(branch `xorn', awaits merge)