Comment 2 for bug 1274516

Revision history for this message
Vladimir Zhbanov (vzhbanov) wrote :

Hi Peter,

> Why did you decide to fix the crash in this way? Neither the
> commit message nor the patch itself is very illuminating.

Consider this patch just fixing the bug and restoring an old
behaviour. (and please make allowances for my English, for me
writing texts in English takes more time than writing patches ;)

> I actually disagree with your justification in the patch that
> "Decision of what to do with any files is not in the competence of
> edarenderer." Working out what to do if an image can't be loaded
> and/or displayed isn't really in the competence of libgeda *or*
> libgedacairo - ideally, it should be decided by the application
> that's using the renderer (for example, it might want to supply a
> different fallback image depending on the current icon theme it's
> using).

I believed edarenderer has to display objects, not create them,
right?

OTOH, I didn't want to make graphical output of gschem and gaf
differ (hence changes in libgeda).

But you're probably right. Every program might decide itself, what
it want to do in such a case.

I thought about creating an object similar to OBJ_PLACEHOLDER for
complexes, but thought up nothing worth taking the trouble.

> I suppose I'd better file another bug about this.

Sure.