Comment 2 for bug 1086522

Revision history for this message
Peter TB Brett (peter-b) wrote :

Some comments about this patch.

1) I like the idea of using ':' as a separator for the options that take multiple arguments, and I can't believe I didn't think about it myself! Would you like to submit a patch to make -m and -s accept it as a separator, and also to update the manpage to show it as the recommended separator? :-)

2) I really *don't* like the --scale=IN:OUT syntax. I find it extremely confusing, and I really don't understand how it works or when it would be useful, even from reading the manpage! I strongly suggest only allowing --scale=FACTOR; I think it would make the --scale feature much easier to understand without any actual loss of functionality.

3) When mentioning metasyntactic variables in the explanation of a command-line option, please put them in italics. For example:

-Scale the output according to a specified scale factor. If one number is
+Scale the output according to a specified scale \fIFACTOR\fR. If one number is

-be equal to OUTPUT_UNIT/INPUT_UNIT.
+be equal to \fIOUTPUT_UNIT\fR/\fIINPUT_UNIT\fR.

Thanks!