Comment 14 for bug 1176324

Brian, on 2013-08-12 you write:

> A fix just went into trunk that will solve for the case where a bad connection would cause not all NOOP to be sent.

Could you confirm or deny whether the patch in question is:

http://bazaar.launchpad.net/~tangent-trunk/gearmand/1.2/revision/853.1.1 :

    Committer: Brian Aker
    Date: 2013-08-11 01:50:44 UTC
    mto: This revision was merged to the branch mainline in revision 854.
    Revision ID: <email address hidden>

    https://launchpad.net/bugs/1196552
    Fix for removing job from durable queue on cancel.

? It mentions NOOP packet-s and has a time stamp that fits your commit "a fix just went into trunk"...

Also, this patch does not apply to 1.0.6 which is the version currently in debian sid and jessie. Do you think it would be easy to port this patch back to 1.0.6, and could you provide any pointers in the right direction? The patch mostly modifies gearman_server_job_cancel() which is not found in 1.0.6's gearmand_con.cc.

Sven points out above that this got introduced between 0.33 and 0.34. Could you point to exactly which commit introduced the problem? That would go a long way towards my understanding of how to create a patch for 0.34 and presumably for 1.0.6 too. My bzr is lacking, there are 33000+ lines of diffs between 0.33 and 0.34 and (apparently) no tags for 0.33 and 0.34 in bzr, so I must admit I gave up trying to identify the culprit.

Which do you think is the path of least resistence: Getting 1.1.12 compiling and installing in a package in Debian sid/jessie or creating a patch for 1.0.6?

Peter