Now, to make net-checker working properly, we need to exclude from testing the networks which are set up on one node (in particular environment) only. So, the fix from description excludes networks from testing when they are defined in template which is in use on one node only. So, if a template is in use on one node only it (with all its networks) is excluded from testing.
But different templates can define the same networks. E.g. template 'common1' is in use on node1 only and it uses networks 'management' and 'private'. E.g. template 'common2' is in use on node2 only and it uses networks 'management' and 'storage'. So, with the current solution (the fix from description) will exclude both template 'common1' and 'common2' from testing. So, 'management' network will not be tested on those nodes but it could be tested as it is in use on more than one node.
Proper fix should look inside the templates which are in use on nodes and filter by networks not by names of the templates.
Now, to make net-checker working properly, we need to exclude from testing the networks which are set up on one node (in particular environment) only. So, the fix from description excludes networks from testing when they are defined in template which is in use on one node only. So, if a template is in use on one node only it (with all its networks) is excluded from testing.
But different templates can define the same networks. E.g. template 'common1' is in use on node1 only and it uses networks 'management' and 'private'. E.g. template 'common2' is in use on node2 only and it uses networks 'management' and 'storage'. So, with the current solution (the fix from description) will exclude both template 'common1' and 'common2' from testing. So, 'management' network will not be tested on those nodes but it could be tested as it is in use on more than one node.
Proper fix should look inside the templates which are in use on nodes and filter by networks not by names of the templates.