Fuel for OpenStack

Need to fix deprecated Puppet parameters

Series newton
Bug #1390099

Bug #1390099 reported by Anastasia Palkina on 2014-11-06

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Fuel for OpenStack	Fix Committed	Medium	Alexey Deryugin	Fuel for OpenStack 10.0
Nominated for Ocata by Ivan Udovichenko
	6.1.x	Fix Committed	Medium	Bartłomiej Piotrowski	Fuel for OpenStack 6.1
	7.0.x	Won't Fix	Medium	Igor Gajsin	Fuel for OpenStack 7.0
	8.0.x	Won't Fix	Medium	Unassigned	Fuel for OpenStack 8.0-updates
	Mitaka	Won't Fix	Medium	MOS Deployment Automation Team	Fuel for OpenStack 9.2
	Newton	Fix Committed	Medium	Alexey Deryugin	Fuel for OpenStack 10.0

Bug Description

"build_id": "2014-11-05_21-28-15",
"ostf_sha": "9c6fadca272427bb933bc459e14bb1bad7f614aa",
"build_number": "79",
"auth_required": true,
"api": "1.0",
"nailgun_sha": "01579a53c2be841dc4cafb0be00213243dde7667",
"production": "docker",
"fuelmain_sha": "35eed79fd6dcfc86a9206ffcd90d385ba5dcca56",
"astute_sha": "c72dac7b31646fbedbfc56a2a87676c6d5713fcf",
"feature_groups": ["mirantis"],
"release": "6.0",
"release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-11-05_21-28-15", "ostf_sha": "9c6fadca272427bb933bc459e14bb1bad7f614aa", "build_number": "79", "api": "1.0", "nailgun_sha": "01579a53c2be841dc4cafb0be00213243dde7667", "production": "docker", "fuelmain_sha": "35eed79fd6dcfc86a9206ffcd90d385ba5dcca56", "astute_sha": "c72dac7b31646fbedbfc56a2a87676c6d5713fcf", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "03c63d4233f6e1c182cc58213cd4542aba5b706d"}}},
"fuellib_sha": "03c63d4233f6e1c182cc58213cd4542aba5b706d"

There are many WARNINGS in puppet.log for HA with deprecated code:

2014-11-06 13:04:12 WARNING

(Scope(Class[Neutron::Agents::L3])) The neutron::l3_agent::newtork_device_mtu parameter is deprecated, use neutron::newtork_device_mtu instead.

2014-11-06 13:04:06 WARNING

(Scope(Class[Nova::Keystone::Auth])) The cinder parameter is deprecated and has no effect.

2014-11-06 13:04:06 WARNING

(Scope(Class[Keystone::Endpoint])) The admin_address parameter is deprecated, use admin_url instead.

2014-11-06 13:04:06 WARNING

(Scope(Class[Keystone::Endpoint])) The internal_address parameter is deprecated, use internal_url instead.

2014-11-06 13:04:06 WARNING

(Scope(Class[Keystone::Endpoint])) The public_address parameter is deprecated, use public_url instead.

2014-11-06 13:04:07 WARNING

(Scope(Class[Keystone])) The bind_host parameter is deprecated, use public_bind_host and admin_bind_host instead.

2014-11-06 12:00:50 WARNING

(Scope(Class[Nova])) The sql_connection parameter is deprecated, use database_connection instead.

Tags:

Revision history for this message

Anastasia Palkina (apalkina) wrote on 2014-11-06:

fuel-snapshot-2014-11-06_14-28-10.tgz Edit (20.4 MiB, application/x-tar)

Bogdan Dobrelya (bogdando) on 2014-11-06

Changed in mos:
status:	New → Confirmed

Revision history for this message

Dmitry Borodaenko (angdraug) wrote on 2014-11-06:

Priority raised to High: any one of these deprecated options can cause breakage of a feature that relies on it (e.g. see bug #1373096).

Changed in mos:
importance:	Medium → High
summary:	- Need to fix deprecated code + Need to fix deprecated Puppet parameters

Revision history for this message

Dmitry Mescheryakov (dmitrymex) wrote on 2014-11-24:

Moving bug to Fuel project since it is purely in puppets

affects:	mos → fuel
Changed in fuel:
milestone:	6.0 → none
milestone:	none → 6.0

Bartłomiej Piotrowski (bpiotrowski) on 2014-11-24

Changed in fuel:
assignee:	Fuel Library Team (fuel-library) → Bartlomiej Piotrowski (bpiotrowski)

Vladimir Kuklin (vkuklin) on 2014-11-26

Changed in fuel:
milestone:	6.0 → 6.1

Bartłomiej Piotrowski (bpiotrowski) on 2014-11-28

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-11-28: Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137743

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-11-28:

Fix proposed to branch: master
Review: https://review.openstack.org/137744

Vladimir Kuklin (vkuklin) on 2014-12-01

Changed in fuel:
importance:	High → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-12-04:

Fix proposed to branch: master
Review: https://review.openstack.org/139081

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-12-05:

Fix proposed to branch: master
Review: https://review.openstack.org/139608

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-30: Change abandoned on fuel-library (master)

Change abandoned by Bart?omiej Piotrowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/137744

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-30:

Change abandoned by Bart?omiej Piotrowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/139081

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-30:

#10

Change abandoned by Bart?omiej Piotrowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/137743

Revision history for this message

Bartłomiej Piotrowski (bpiotrowski) wrote on 2015-02-02:

#11

The deprecation messages are slowly fixed with upstream module merge.

Changed in fuel:
status:	In Progress → Invalid

Revision history for this message

Anastasia Palkina (apalkina) wrote on 2015-02-02:

#12

Reproduced without any problems on ISO #92

"build_id": "2015-02-01_22-55-01", "ostf_sha": "c9100263140008abfcc2704732e98fbdfd644068", "build_number": "92", "release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-02-01_22-55-01", "ostf_sha": "c9100263140008abfcc2704732e98fbdfd644068", "build_number": "92", "api": "1.0", "nailgun_sha": "c0932eb5c2aa7fd1e13a999cb1b4bf5aff101c3b", "production": "docker", "python-fuelclient_sha": "2ea7b3e91c1d2ff85110bf5abb161a6f4e537358", "astute_sha": "ed5270bf9c6c1234797e00bd7d4dd3213253a413", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "", "fuellib_sha": "c5e4a0410ba66f9e9911f62b3b71c0b9c29aed6e"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "c0932eb5c2aa7fd1e13a999cb1b4bf5aff101c3b", "production": "docker", "python-fuelclient_sha": "2ea7b3e91c1d2ff85110bf5abb161a6f4e537358", "astute_sha": "ed5270bf9c6c1234797e00bd7d4dd3213253a413", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "", "fuellib_sha": "c5e4a0410ba66f9e9911f62b3b71c0b9c29aed6e"

1. Create new environment (CentOS)
2. Choose neutron, GRE
3. Choose Ceilometer
4. Add 3 controller+cinder+mongo, 2 compute, 1 cinder, 2 mongo
5. Start deployment. It was successful
6. See puppet.log for first controller (node-6) and you can see many warnings about deprecated code. For example:

2015-02-02 11:44:56 WARNING

(Scope(Class[Horizon])) The keystone_host parameter is deprecated, use keystone_url instead.

2015-02-02 11:44:56 WARNING

(Scope(Class[Horizon])) The keystone_scheme parameter is deprecated, use keystone_url instead.

2015-02-02 11:44:56 WARNING

(Scope(Class[Horizon])) swift parameter is deprecated and has no effect.

2015-02-02 11:44:49 WARNING

(Scope(Class[Nova])) The sql_connection parameter is deprecated, use database_connection instead.

2015-02-02 11:44:44 WARNING

(Scope(Class[Nova::Keystone::Auth])) The cinder parameter is deprecated and has no effect.

2015-02-02 11:44:43 WARNING

(Scope(Class[Keystone::Endpoint])) The admin_address parameter is deprecated, use admin_url instead.

2015-02-02 11:44:43 WARNING

(Scope(Class[Keystone::Endpoint])) The internal_address parameter is deprecated, use internal_url instead.

2015-02-02 11:44:43 WARNING

(Scope(Class[Keystone::Endpoint])) The public_address parameter is deprecated, use public_url instead.

2015-02-02 11:44:43 WARNING

(Scope(Class[Keystone])) The bind_host parameter is deprecated, use public_bind_host and admin_bind_host instead.

Reproduced without any problems on ISO #92

2015-02-02 11:44:56	WARNING

(Scope(Class[Horizon])) The keystone_host parameter is deprecated, use keystone_url instead.

2015-02-02 11:44:56	WARNING

(Scope(Class[Horizon])) The keystone_scheme parameter is deprecated, use keystone_url instead.

2015-02-02 11:44:56	WARNING

(Scope(Class[Horizon])) swift parameter is deprecated and has no effect.

2015-02-02 11:44:49	WARNING

(Scope(Class[Nova])) The sql_connection parameter is deprecated, use database_connection instead.

2015-02-02 11:44:44	WARNING

(Scope(Class[Nova::Keystone::Auth])) The cinder parameter is deprecated and has no effect.

2015-02-02 11:44:43	WARNING

(Scope(Class[Keystone::Endpoint])) The admin_address parameter is deprecated, use admin_url instead.

2015-02-02 11:44:43	WARNING

(Scope(Class[Keystone::Endpoint])) The internal_address parameter is deprecated, use internal_url instead.

2015-02-02 11:44:43	WARNING

(Scope(Class[Keystone::Endpoint])) The public_address parameter is deprecated, use public_url instead.

2015-02-02 11:44:43	WARNING

(Scope(Class[Keystone])) The bind_host parameter is deprecated, use public_bind_host and admin_bind_host instead.

Changed in fuel:
status:	Invalid → Confirmed

Revision history for this message

Anastasia Palkina (apalkina) wrote on 2015-02-02:

#13

fuel-snapshot-2015-02-02_13-08-18.tgz Edit (86.1 MiB, application/x-tar)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-03: Fix merged to fuel-library (master)

#14

Reviewed: https://review.openstack.org/139608
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=9f249265fa3872ed1f71283c1f40bf0688501e56
Submitter: Jenkins
Branch: master

commit 9f249265fa3872ed1f71283c1f40bf0688501e56
Author: Bartłomiej Piotrowski <email address hidden>
Date: Fri Dec 5 13:14:09 2014 +0100

Replace Keystone's bind_host with {public,admin}_bind_host.

Change-Id: Iaf0c023e3d52d1073135698decb9070319d1d41b
Partial-Bug: 1390099

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-03: Related fix proposed to fuel-library (master)

#15

Related fix proposed to branch: master
Review: https://review.openstack.org/152467

OpenStack Infra (hudson-openstack) on 2015-02-03

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-03: Change abandoned on fuel-library (master)

#16

Change abandoned by Bart?omiej Piotrowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/152467
Reason: Duplicate of 137743

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-02-04: Fix merged to fuel-library (master)

#17

Reviewed: https://review.openstack.org/137743
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=0b6cfb575cc0d2ee2b0da28e5f3fedc4e9b492d0
Submitter: Jenkins
Branch: master

commit 0b6cfb575cc0d2ee2b0da28e5f3fedc4e9b492d0
Author: Bartłomiej Piotrowski <email address hidden>
Date: Thu Nov 27 13:41:29 2014 +0100

Remove deprecated cinder parameter from keystone manifest

    The parameter has been deprecated in upstream Nova module and has
    currently no other effect than displaying a warning about its
    deprecation.

Partial-Bug: 1390099
Change-Id: Ib4e99af35a4892f2b43744ba0cd41b2d58d6390d

OpenStack Infra (hudson-openstack) on 2015-02-18

Changed in fuel:
assignee:	Bartlomiej Piotrowski (bpiotrowski) → Sergii Golovatiuk (sgolovatiuk)

Bartłomiej Piotrowski (bpiotrowski) on 2015-02-25

Changed in fuel:
assignee:	Sergii Golovatiuk (sgolovatiuk) → Bartlomiej Piotrowski (bpiotrowski)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-03-02:

#18

Reviewed: https://review.openstack.org/137744
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=5c31cd193c30aff54768a7d5bb5c97b66bd14d71
Submitter: Jenkins
Branch: master

commit 5c31cd193c30aff54768a7d5bb5c97b66bd14d71
Author: Bartłomiej Piotrowski <email address hidden>
Date: Tue Feb 3 12:18:24 2015 +0100

Fix deprecation warnings related to openstack nova class

sql_connection parameter has been renamed to database_connection in the
upstream module.

Partial-Bug: 1390099
Change-Id: I6181a6f70e3fbb3bc302b2fac2f58e23df5191f8

Revision history for this message

Vladimir Kuklin (vkuklin) wrote on 2015-04-07:

#19

We fixed as much as possible deprecated parameters for 6.1. We will continue this activity for 7.0

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-07-20: Fix proposed to fuel-library (master)

#20

Fix proposed to branch: master
Review: https://review.openstack.org/203626

Revision history for this message

Igor Gajsin (igajsin) wrote on 2015-08-19:

#21

We can't fix it due to soft code freeze. Postpone to Fuel 8.0.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-08-25: Change abandoned on fuel-library (master)

#22

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/203626
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Dmitry Pyzhov (dpyzhov) on 2015-10-12

Changed in fuel:
milestone:	7.0 → 8.0
status:	Fix Committed → Confirmed
no longer affects:	fuel/8.0.x

Dmitry Pyzhov (dpyzhov) on 2015-10-21

tags:

added: area-library

Stanislaw Bogatkin (sbogatkin) on 2015-12-14

tags:

added: team-bugfix

Igor Gajsin (igajsin) on 2015-12-24

Changed in fuel:
status:	Confirmed → Won't Fix

Matthew Mosesohn (raytrac3r) on 2015-12-28

tags:

added: area-mos
removed: area-library team-bugfix

OpenStack Infra (hudson-openstack) on 2016-06-30

Changed in fuel:
status:	Won't Fix → In Progress

Denis Egorenko (degorenko) on 2016-07-11

tags:

added: 10.0-reviewed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-26: Fix merged to fuel-library (master)

#23

Reviewed: https://review.openstack.org/336074
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=eb0ae0e5973f884efc4bf7d55d3bb1e591f79638
Submitter: Jenkins
Branch: master

commit eb0ae0e5973f884efc4bf7d55d3bb1e591f79638
Author: Alexey Deryugin <email address hidden>
Date: Thu Jun 30 18:02:19 2016 +0300

Remove deprecated parameters

Change-Id: I7f093413d2c2b258b25508419a0ab58a85f8778f
Closes-Bug: #1390099

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

Ivan Berezovskiy (iberezovskiy) wrote on 2016-07-27:

#24

Confirmed for 9.1 because of https://bugs.launchpad.net/mos/+bug/1606943

Revision history for this message

Ivan Berezovskiy (iberezovskiy) wrote on 2016-09-08:

#25

It would be better to switch to non-deprecated parameters usage right after 9.1 is done.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-14: Fix included in openstack/fuel-library 10.0.0rc1

#26

This issue was fixed in the openstack/fuel-library 10.0.0rc1 release candidate.

Vitaly Sedelnik (vsedelnik) on 2016-10-24

tags:

added: area-puppet
removed: area-mos

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-08: Fix proposed to fuel-library (master)

#27

Fix proposed to branch: master
Review: https://review.openstack.org/394943

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-11: Fix merged to fuel-library (master)

#28

Reviewed: https://review.openstack.org/394943
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=5a6fea2a760a9014121985f26e0fd04bf834dfeb
Submitter: Jenkins
Branch: master

commit 5a6fea2a760a9014121985f26e0fd04bf834dfeb
Author: Mykyta Karpin <email address hidden>
Date: Tue Nov 8 11:35:16 2016 +0200

Adapt fuel-library to removal of old authtoken parameters

    These patches https://review.openstack.org/#/q/topic:old_authtoken
    are removing old puppet authtoken parameters and now we need to use
    parameters from keystone::authtoken class in each affected module

Closes-Bug: #1640083
Partial-Bug: #1390099

Change-Id: Ife3ed88237ce735b2a068415b1e57fca93498dcd

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-07: Fix included in openstack/fuel-library 10.0.0

#29

This issue was fixed in the openstack/fuel-library 10.0.0 release.