cinder uses glance_api_version=1 with ceph

[Andrey Grebennikov]

Fuel 5.1

Choose Ceph for both Cinder and Glance.

After the deployment when tried to create a volume from image it copies the image from ceph to controller (glance) node and then uploads back to cinder as a volume.

The problem is that the option glance_api_version=2 has been deprecated in the cinder::backend::rbd manifest and was moved to cinder::glance which never executes.

[Dmitry Borodaenko (angdraug)]

The problem was caused by pulling the upstream puppet-cinder module:
https://review.openstack.org/#/c/101166/3/deployment/puppet/cinder/manifests/backend/rbd.pp

In this version, setting glance_api_version from cinder::backend::rbd is deprecated in favor of doing that via cinder::glance. We missed that, and since we didn't add declaration of cinder::glance in the followup adaptation commit, this option is no longer set by Fuel.

We need to introduce a test (preferrably two: rspec check for glance_api_version and integration test for rbd snapshots being used for cinder volumes) to prevent this regression in the future.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124123

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/124528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124123
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=c8f374144f9e8c3f3e7a97dfad3a952a6fd7afba
Submitter: Jenkins
Branch: master

commit c8f374144f9e8c3f3e7a97dfad3a952a6fd7afba
Author: Dmitry Borodaenko <email address hidden>
Date: Thu Sep 25 10:59:39 2014 -0700

    Declare cinder::glance to set glance_api_version

    Prior to syncing upstream cinder module, glance_api_version was set from
    cinder::backend::rbd. New upstream moved this to cinder::glance.

    Change-Id: Ied9f4308b998e9f345449e03a00221de41261e85
    Closes-Bug: #1373096

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124528
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=8f8b9f1b19d7317a0e62e41723b571245baf26c6
Submitter: Jenkins
Branch: stable/5.1

commit 8f8b9f1b19d7317a0e62e41723b571245baf26c6
Author: Dmitry Borodaenko <email address hidden>
Date: Thu Sep 25 10:59:39 2014 -0700

    Declare cinder::glance to set glance_api_version

    Prior to syncing upstream cinder module, glance_api_version was set from
    cinder::backend::rbd. New upstream moved this to cinder::glance.

    Change-Id: Ied9f4308b998e9f345449e03a00221de41261e85
    Closes-Bug: #1373096

[Dmitry Borodaenko (angdraug)]

Release notes update: https://review.openstack.org/126040