Replace all occurrences of $ with $$ in vCenter input values
- OpenStack services may reference to previously defined variable in
configuration files using $ (dollar sign), e.g. 'metadata_host =
$my_ip'. Interpolation can be avoided by using $$. Passwords often
contain metachars and $ is one of them. We must replace all $
occurrences with $$, otherwise service will fail to start because it
cannot interpolate non-existing variable.
- add static method escape_dollar() to VMwareDeploymentSerializerMixin
class that implements conversion
- also handle username and regular expression that is used for datastore
search
- provide input values with '$' in test fixture vmware_attributes.json
- modify integration test
Reviewed: https:/ /review. openstack. org/178699 /git.openstack. org/cgit/ stackforge/ fuel-web/ commit/ ?id=3ef6dc0ef57 bb286ea81e53a7f 3495cd3a5ca315
Committed: https:/
Submitter: Jenkins
Branch: master
commit 3ef6dc0ef57bb28 6ea81e53a7f3495 cd3a5ca315
Author: Igor Zinovik <email address hidden>
Date: Wed Apr 29 17:40:39 2015 +0300
Replace all occurrences of $ with $$ in vCenter input values
- OpenStack services may reference to previously defined variable in tSerializerMixi n attributes. json
configuration files using $ (dollar sign), e.g. 'metadata_host =
$my_ip'. Interpolation can be avoided by using $$. Passwords often
contain metachars and $ is one of them. We must replace all $
occurrences with $$, otherwise service will fail to start because it
cannot interpolate non-existing variable.
- add static method escape_dollar() to VMwareDeploymen
class that implements conversion
- also handle username and regular expression that is used for datastore
search
- provide input values with '$' in test fixture vmware_
- modify integration test
Change-Id: I0d7d9f2d7f0cca a3310c865a7f467 c377c067442
Closes-bug: #1436083