Comment 6 for bug 1736098

Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

Alexander, I deeply investigated this and came to a conclusion that there is no bug in nailgun. Here is my explanation. The logging system in nailgun designed to use several output handlers, one of them is WatchedFileHandler from the python library which should close and re-open the file if it has changed between writes, mostly to use in conjunction with logrotate. This is used because of the huge amount of logging for API calls when the logging level is set to `debug` and very frequent log rotation in fuel's debug configuration. There should not be any problem if logrotate is working, OTOH the logs directory space exhaustion is an exceptional situation and should be treated accordingly. Ignoring logger errors violates the 'fail-fast' principle (https://en.wikipedia.org/wiki/Fail-fast) which is common in software development nowadays.

Using a syslog/udp handler is not an option too - it demands refactoring of the whole logging process in nailgun which is not acceptable for a stable release.

Therefore I'm closing this as Invalid.

P.S. I can give you a patch to ignore exceptions from the logger, but it never will be merged in our repos.