'/root/openrc's resource duplicate declaration

[Mikhail Zhnichkov]

User configures Username(root) and Home directory(/root) in Operating System Access, and will throw the error that Credentials_file[/root/openrc] is already declared in deployment.

We already fix it in https://bugs.launchpad.net/fuel/+bug/1636472, but this bug also occurs in openrc_generate task

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408512

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408512
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=39af6a532adedc553d9fbd4a6c67e6e4ab4273b3
Submitter: Jenkins
Branch: master

commit 39af6a532adedc553d9fbd4a6c67e6e4ab4273b3
Author: Mikhail <email address hidden>
Date: Thu Dec 8 13:19:13 2016 +0400

    Fix duplicate declaration in openrc_generate task

    User configures Username(root) and Home directory(/root) in
    Operating System Access, and will throw the error that
    Credentials_file[/root/openrc] is already declared in deployment.

    Change-Id: Ic870f313b5a1fd0c691039eb11699efbffe23aba
    Closes-Bug: #1648359

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/410770

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/410771

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410771
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=fd075f053876a895a26800e99ac1ebd6eb96002a
Submitter: Jenkins
Branch: stable/newton

commit fd075f053876a895a26800e99ac1ebd6eb96002a
Author: Mikhail <email address hidden>
Date: Thu Dec 8 13:19:13 2016 +0400

    Fix duplicate declaration in openrc_generate task

    User configures Username(root) and Home directory(/root) in
    Operating System Access, and will throw the error that
    Credentials_file[/root/openrc] is already declared in deployment.

    Change-Id: Ic870f313b5a1fd0c691039eb11699efbffe23aba
    Closes-Bug: #1648359
    (cherry picked from commit 39af6a532adedc553d9fbd4a6c67e6e4ab4273b3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/410770
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a0db29e485f231a81e9c32325fe36044d248336e
Submitter: Jenkins
Branch: stable/mitaka

commit a0db29e485f231a81e9c32325fe36044d248336e
Author: Mikhail <email address hidden>
Date: Thu Dec 8 13:19:13 2016 +0400

    Fix duplicate declaration in openrc_generate task

    User configures Username(root) and Home directory(/root) in
    Operating System Access, and will throw the error that
    Credentials_file[/root/openrc] is already declared in deployment.

    Change-Id: Ic870f313b5a1fd0c691039eb11699efbffe23aba
    Closes-Bug: #1648359
    (cherry picked from commit 39af6a532adedc553d9fbd4a6c67e6e4ab4273b3)

[TatyanaGladysheva (tgladysheva)]

Verified on 9.2 snapshot #567.

Steps to verify:
1. Deploy Fuel 9.0 RC2 from image (Build 495)
2. Upgrade the fuel master node to 9.2
3. Change operator_user's name value from 'fueladmin' to 'root' and operator_user's homedir value from '/home/fueladmin' to '/root' in /usr/lib/python2.7/site-packages/nailgun/fixtures/openstack.yaml
4. systemctl restart nailgun
5. Apply workaround for bug https://bugs.launchpad.net/fuel/+bug/1651416 (changes in openstack.yaml are not applied after upgrade to 9.2 by default, we need to set name and homedir values manually in db):
sudo -u postgres psql
\c nailgun
begin;
update releases set attributes_metadata = regexp_replace(attributes_metadata, '"value": "fueladmin"', '"value": "root"');
update releases set attributes_metadata = regexp_replace(attributes_metadata, '"value": "\/home\/fueladmin"', '"value": "/root"');
commit;
6. Create cluster with 1 controller, add mos9.0-proposed repo and deploy it

Actual results:
Deployment is finished successfully.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 11.0.0.0rc1 release candidate.