List of advanced settings to be changed is hard-coded in Nailgun and Fuel Library

Bug #1580522 reported by Vladimir Kuklin
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Vladimir Kuklin
Mitaka
Fix Released
High
Vladimir Kuklin
Newton
Fix Committed
High
Vladimir Kuklin

Bug Description

With 8.0 we have an option to change settings for OpenStack and related services. But this set of options is hardcoded in Nailgun and other services are not supporting it as well, although we should at least allow a user to provide a plugin for this and be able to get this data serialized through nailgun into $.configuration namespace.

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/304598
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5b2607ab8f371e3479775f09e6ebc8915813ab17
Submitter: Jenkins
Branch: master

commit 5b2607ab8f371e3479775f09e6ebc8915813ab17
Author: Vladimir Kuklin <email address hidden>
Date: Tue Apr 12 16:05:26 2016 +0300

    Nailgun Fixes for smart configuration changes support

    Simply unhardcode the handler for $.configuration namespace
    to allow a user to modify anything he wants in this namespace.
    The list of modifyable sections on '$.configuration' namespace of astute.yaml
    should not be hardcoded - this makes no sense as support of these pieces
    is implemented on fuel library and plugins side. Hardcoding the list
    will make it impossible for a plugin developer to reuse configuration
    changes feature to support configuration options for plugin.

    DocImpact

    Partial-bug: #1580522

    Change-Id: I4eb18461c0a4f337b649abfcd099259965290ff5

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/318801

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/318801
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f40b45f5baf4f863ddc9848dc6e3215d001e2433
Submitter: Jenkins
Branch: stable/mitaka

commit f40b45f5baf4f863ddc9848dc6e3215d001e2433
Author: Vladimir Kuklin <email address hidden>
Date: Tue Apr 12 16:05:26 2016 +0300

    Nailgun Fixes for smart configuration changes support

    Simply unhardcode the handler for $.configuration namespace
    to allow a user to modify anything he wants in this namespace.
    The list of modifyable sections on '$.configuration' namespace of astute.yaml
    should not be hardcoded - this makes no sense as support of these pieces
    is implemented on fuel library and plugins side. Hardcoding the list
    will make it impossible for a plugin developer to reuse configuration
    changes feature to support configuration options for plugin.

    DocImpact

    Partial-bug: #1580522

    Change-Id: I4eb18461c0a4f337b649abfcd099259965290ff5
    (cherry picked from commit 5b2607ab8f371e3479775f09e6ebc8915813ab17)

tags: added: in-stable-mitaka
Revision history for this message
Ksenia Svechnikova (kdemina) wrote :

This changes lead to errors in test, that check validation of uploaded configs for unsupported services: https://bugs.launchpad.net/fuel/+bug/1584693

Could you please clarify, that now we can upload config for any configs (ex. cinder:

configuration:
  cinder_config:
    foo:
      value: bar
)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/319927

Changed in fuel:
assignee: Vladimir Kuklin (vkuklin) → Ksenia Demina (kdemina)
assignee: Ksenia Demina (kdemina) → Vladimir Kuklin (vkuklin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-qa (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/319937

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/319927
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=2e8618651c6c6daff6bf5d17317f2cf598a4c002
Submitter: Jenkins
Branch: master

commit 2e8618651c6c6daff6bf5d17317f2cf598a4c002
Author: Ksenia Demina <email address hidden>
Date: Mon May 23 16:10:04 2016 +0300

    Get rid of check_wrong_config test

    There was a list of hardcoded services that allow us to use
    service-reconfiguration. Now there is no strict limitation
    on services that could be configured with this feature.
    This mean that test check_wrong_config is deprecated and should be
    deleted

    Change-Id: I729bf0235eea525cc0464346ca791ca7733e5de9
    Related-Bug: #1580522
    Closes-bug: #1584693

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-qa (stable/mitaka)

Reviewed: https://review.openstack.org/319937
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=bbeba3e4e30292d6d50bfa7bfce6c3dfe0dfd9ac
Submitter: Jenkins
Branch: stable/mitaka

commit bbeba3e4e30292d6d50bfa7bfce6c3dfe0dfd9ac
Author: Ksenia Demina <email address hidden>
Date: Mon May 23 16:10:04 2016 +0300

    Get rid of check_wrong_config test

    There was a list of hardcoded services that allow us to use
    service-reconfiguration. Now there is no strict limitation
    on services that could be configured with this feature.
    This mean that test check_wrong_config is deprecated and should be
    deleted

    Change-Id: I729bf0235eea525cc0464346ca791ca7733e5de9
    Related-Bug: #1580522
    Closes-bug: #1584693

Revision history for this message
Alexey Shtokolov (ashtokolov) wrote :

Library part https://review.openstack.org/#/c/301088/ is waiting for the update of the ISO on CI

Changed in fuel:
assignee: Vladimir Kuklin (vkuklin) → Alexey Shtokolov (ashtokolov)
Changed in fuel:
assignee: Alexey Shtokolov (ashtokolov) → Vladimir Kuklin (vkuklin)
tags: added: tech-debt
tags: added: life-cycle-management
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/301088
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=aa5bebf811bb4a49f089e78a9ef164b7a8108284
Submitter: Jenkins
Branch: master

commit aa5bebf811bb4a49f089e78a9ef164b7a8108284
Author: Vladimir Kuklin <email address hidden>
Date: Mon Apr 4 15:31:14 2016 +0300

    Fix support for changing settings for some of the services

    Allow a user to change particular openstack and misc
    services configuration.

    Supports:
      ceilometer
      cinder
      glance
      haproxy
      heat
      mysql
      rabbitmq

    DocImpact

    Closes-bug: #1580522

    Change-Id: I2933846f78c94933419d4dfd3dfbe49178172ff9

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/323558

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/323558
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=45090021ab17fd2931e14e1c695a6ff861954e4b
Submitter: Jenkins
Branch: stable/mitaka

commit 45090021ab17fd2931e14e1c695a6ff861954e4b
Author: Vladimir Kuklin <email address hidden>
Date: Mon Apr 4 15:31:14 2016 +0300

    Fix support for changing settings for some of the services

    Allow a user to change particular openstack and misc
    services configuration.

    Supports:
      ceilometer
      cinder
      glance
      haproxy
      heat
      mysql
      rabbitmq

    DocImpact

    Closes-bug: #1580522

    Change-Id: I2933846f78c94933419d4dfd3dfbe49178172ff9

tags: added: on-verification
Revision history for this message
Andrey Lavrentyev (alavrentyev) wrote :

Verified on 9.0-mos #450

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 450
cat /etc/fuel_build_number:
 450
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8723.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8435.noarch
 rubygem-astute-9.0.0-1.mos748.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8723.noarch
 fuel-notify-9.0.0-1.mos8435.noarch
 nailgun-mcagents-9.0.0-1.mos748.noarch
 python-fuelclient-9.0.0-1.mos323.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8435.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-misc-9.0.0-1.mos8435.noarch
 fuel-library9.0-9.0.0-1.mos8435.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2715.noarch
 fuel-ostf-9.0.0-1.mos935.noarch
 fuelmenu-9.0.0-1.mos272.noarch
 fuel-nailgun-9.0.0-1.mos8723.noarch

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.