Not doing so leads to bash errors when string contains spaces.
Specifically, variable OCF_RESKEY_CRM_meta_notify_stop_uname can
contain spaces when several nodes are stopped simultaneously and
that leads to error described in the bug referenced below.
Regarding other variables quoted in this change "...promote_uname",
"...master_uname" and "...demote_uname" - in our case they never
should be empty, since we can have only one master. But better safe
than sorry.
Reviewed: https:/ /review. openstack. org/259363 /git.openstack. org/cgit/ openstack/ fuel-library/ commit/ ?id=97d36d0bea8 f22ab5029a2ddff 0f5a49d0d28d23
Committed: https:/
Submitter: Jenkins
Branch: stable/7.0
commit 97d36d0bea8f22a b5029a2ddff0f5a 49d0d28d23
Author: Dmitry Mescheryakov <email address hidden>
Date: Fri Dec 18 13:09:23 2015 +0300
Quote vars when checking them on emptiness
Not doing so leads to bash errors when string contains spaces. CRM_meta_ notify_ stop_uname can
Specifically, variable OCF_RESKEY_
contain spaces when several nodes are stopped simultaneously and
that leads to error described in the bug referenced below.
Regarding other variables quoted in this change "...promote_uname", .master_ uname" and "...demote_uname" - in our case they never
"..
should be empty, since we can have only one master. But better safe
than sorry.
Change-Id: I1447f58e897cc1 fe6b9884c3b4cd4 f950dd9cecb
Closes-Bug: #1527518