[library][idempotency] Compute and compute-nova.pp tasks have few issues with idempotency

Bug #1526895 reported by Roman Sokolkov on 2015-12-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Medium
Michael Polenchuk

Bug Description

First, i see at least 5 not covered issues in compute task. Please take look on full log below. It also interfere with "openstack-network/compute-nova.pp" task.

Both tasks try to manage resources:
- Nova_config[DEFAULT/network_device_mtu]
- /Service[nova-compute]

Environment:
- MOS 8.0 (fuel-8.0-284-2015-12-10_19-42-00.iso)

Full log:
root@node-2:~/lcm# puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/roles/compute.pp
Notice: Compiled catalog for node-2.domain.tld in environment production in 1.09 seconds
Notice: /Stage[main]/Nova::Compute/Nova_config[DEFAULT/network_device_mtu]/ensure: current_value present, should be absent (noop)
Notice: /Stage[main]/Openstack::Compute/Notify[Module openstack cannot notify service nova-compute on packages update]/message: current_value absent, should be Module openstack cannot notify service nova-compute on packages update (noop)
Notice: /Stage[main]/Openstack::Compute/Notify[Module openstack cannot notify service nova-computeon packages update]/message: current_value absent, should be Module openstack cannot notify service nova-computeon packages update (noop)
Notice: /Stage[main]/Openstack::Compute/Tweaks::Ubuntu_service_override[nova-compute]/File[create_nova-compute_override]/content: current_value {md5}d41d8cd98f00b204e9800998ecf8427e, should be {md5}3c78b35502b2693fefdfc51cba3a53a5 (noop)
Notice: /Stage[main]/Openstack::Compute/Service[cpufrequtils]/ensure: current_value stopped, should be running (noop)
Notice: /Stage[main]/Openstack::Compute/Tweaks::Ubuntu_service_override[nova-compute]/Exec[remove_nova-compute_override]/returns: current_value notrun, should be 0 (noop)
Notice: Tweaks::Ubuntu_service_override[nova-compute]: Would have triggered 'refresh' from 2 events
Notice: Class[Openstack::Compute]: Would have triggered 'refresh' from 4 events
Notice: /Stage[main]/Nova/Exec[post-nova_config]: Would have triggered 'refresh' from 1 events
Notice: /Stage[main]/Nova::Compute/Nova::Generic_service[compute]/Service[nova-compute]/ensure: current_value running, should be stopped (noop)
Notice: /Stage[main]/Nova::Compute/Nova::Generic_service[compute]/Service[nova-compute]: Would have triggered 'refresh' from 1 events
Notice: Nova::Generic_service[compute]: Would have triggered 'refresh' from 2 events
Notice: Class[Nova::Compute]: Would have triggered 'refresh' from 2 events
Notice: Class[Nova]: Would have triggered 'refresh' from 1 events
Notice: Stage[main]: Would have triggered 'refresh' from 3 events
Notice: Finished catalog run in 2.06 seconds

root@node-2:~/lcm# puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/openstack-network/compute-nova.pp
Notice: Scope(Class[main]): MODULAR: openstack-network/compute-nova.pp
Notice: Compiled catalog for node-2.domain.tld in environment production in 0.44 seconds
Notice: /Stage[main]/Main/Nova_config[DEFAULT/network_device_mtu]/ensure: current_value absent, should be present (noop)
Notice: /Stage[main]/Main/Exec[wait-for-int-br]/returns: current_value notrun, should be 0 (noop)
Notice: /Stage[main]/Main/Tweaks::Ubuntu_service_override[nova-network]/File[create_nova-network_override]/ensure: current_value absent, should be present (noop)
Notice: Tweaks::Ubuntu_service_override[nova-network]: Would have triggered 'refresh' from 1 events
Notice: /Stage[main]/Main/Service[nova-compute]/ensure: current_value stopped, should be running (noop)
Notice: Class[Main]: Would have triggered 'refresh' from 4 events
Notice: Stage[main]: Would have triggered 'refresh' from 1 events
Notice: Finished catalog run in 1.79 seconds

description: updated
description: updated
summary: - [library][idempotency] Compute task has few issues with idempotency
+ [library][idempotency] Compute and compute-nova.pp tasks have few issues
+ with idempotency
Ilya Kutukov (ikutukov) on 2015-12-16
Changed in fuel:
milestone: none → 8.0-updates
assignee: nobody → Fuel Library Team (fuel-library)
importance: Undecided → Medium
status: New → Confirmed
tags: added: area-library
Ilya Kutukov (ikutukov) on 2015-12-17
Changed in fuel:
milestone: 8.0-updates → 8.0
Dmitry Pyzhov (dpyzhov) on 2015-12-29
Changed in fuel:
milestone: 8.0 → 9.0
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Michael Polenchuk (mpolenchuk)

Fix proposed to branch: master
Review: https://review.openstack.org/274737

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
assignee: Michael Polenchuk (mpolenchuk) → Bartłomiej Piotrowski (bpiotrowski)
Changed in fuel:
assignee: Bartłomiej Piotrowski (bpiotrowski) → Michael Polenchuk (mpolenchuk)
Changed in fuel:
assignee: Michael Polenchuk (mpolenchuk) → Alex Schultz (alex-schultz)
Changed in fuel:
assignee: Alex Schultz (alex-schultz) → Michael Polenchuk (mpolenchuk)

Reviewed: https://review.openstack.org/274737
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f97b186bfdbaac727c1e418f4c4061f1ddd8349d
Submitter: Jenkins
Branch: master

commit f97b186bfdbaac727c1e418f4c4061f1ddd8349d
Author: Michael Polenchuk <email address hidden>
Date: Mon Feb 1 18:51:46 2016 +0300

    Fix idempotency of compute tasks

    * make one entry point for network_device_mtu
    * disable start of nova-compute service
    * mend of cpufrequtils resources

    DocImpact: "integration bridge waiting" has been moved to
    enable_nova_compute_service task where it actually should be used.
    Change-Id: Ide46e5053dadeb41b7fdafcdc3b49fd6db1b8f3d
    Closes-Bug: #1526895

Changed in fuel:
status: In Progress → Fix Committed
Sergey Novikov (snovikov) wrote :

Verified on 9.0 MOS iso #366

related bug https://bugs.launchpad.net/fuel/+bug/1583183

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers