[LCM][Task idempotecy] The task "openstack-network-compute-nova" is not idempotent

[Sergey Novikov]

Steps to reproduce:
 1. deploy env with 3 comtrollers + 2 computes
 2. Rerun task "openstack-network-compute-nova" against some compute node
 # Run task via fuel CLI client
 >fuel node --node-id <compute_id> --tasks openstack-network-compute-nova
 #or the direct run of corresponding puppet manifest on compute node
 >puppet apply --noop /etc/puppet/modules/openstack_tasks/examples/openstack-network/compute-nova.pp

Expected results: No resource changes
Actual result: The following resources were changed
    - Exec[undefine_libvirt_default_network]
Reproducibility:
Issue is reproduced after only the fresh full deployment. if you apply manifest a twice then second run will be idempotent. Thus, may be, it's expected changes, please confirm this or not

Description of the environment:
env was built from ISO MOS 9.0 #364
Additional information:
puppet's output:
http://paste.openstack.org/show/497506/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/318929

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318929
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=52f0888af273e0ae9867ee6b5b645e0565732428
Submitter: Jenkins
Branch: master

commit 52f0888af273e0ae9867ee6b5b645e0565732428
Author: Maciej Relewicz <email address hidden>
Date: Thu May 19 15:09:13 2016 +0200

    Fix compute_nova.pp idempotency granular task.

    Change-Id: I29085ea00f3ad96590d7506726263535b2d4484d
    Closes-Bug: #1583183

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/319261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/319261
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=844e0eb72dddf9a7c07bf73ca8ff8d04fbd7ffb1
Submitter: Jenkins
Branch: stable/mitaka

commit 844e0eb72dddf9a7c07bf73ca8ff8d04fbd7ffb1
Author: Maciej Relewicz <email address hidden>
Date: Thu May 19 15:09:13 2016 +0200

    Fix compute_nova.pp idempotency granular task.

    Change-Id: I29085ea00f3ad96590d7506726263535b2d4484d
    Closes-Bug: #1583183
    (cherry picked from commit 52f0888af273e0ae9867ee6b5b645e0565732428)

[Sergey Novikov (snovikov)]

Verified on 9.0 MOS iso #392

[Sergey Novikov (snovikov)]

I've made a mistake during the verification. Now this issue is reproduced on 9.0 MOS iso #395

http://paste.openstack.org/show/505340/

[Maciej Relewicz (rlu)]

task is indempotent, but problem is with libvird init script. So this case should be reassigned to mos team. They should prepare fix for it.

Problem description:

# service libvirtd start; service libvirtd status; virsh net-list --all
libvirtd start/running, process 32555
libvirtd start/running, process 32555
error: failed to connect to the hypervisor
error: no valid connection
error: Failed to connect socket to '/var/run/libvirt/libvirt-sock': No such file or directory

So, fix is for it is init script to wait until the service is ready for connections.

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: master
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/21417

[Roman Vyalov (r0mikiam)]

reassigned to mos-linux team, because the problem related to the base package

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/21417
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: ce1c254775ecba971186cd6b71d0fedfde0b9576
Author: Ivan Suzdal <email address hidden>
Date: Tue May 31 12:40:46 2016

Wait for socket ready in libvirtd upstart job.

Upstart job switch state to running before
libvirtd socket is created.
Patch backported from upstream (LP: #1455608, LP: #1571209).

Change-Id: Idf96c9119501dea952a5807b884d5851e7b3fabc
Related-Bug: #1583183

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: 9.0
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/21451

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Ivan Suzdal <email address hidden> on branch: 9.0
Review: https://review.fuel-infra.org/21451

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: master
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/21560

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/21560
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 56648a451e62a6e3fcfb164c2c39c576b0d70060
Author: Ivan Suzdal <email address hidden>
Date: Fri Jun 3 09:52:58 2016

Wait for socket ready in libvirtd upstart job.

Upstart job switch state to running before
libvirtd socket is created.
Patch backported from upstream (LP: #1455608, LP: #1571209).

Related-Bug: #1583183

Change-Id: I669db8175044e96ba586f036100a6ed9508cda6d

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: 9.0
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/21636

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/21636
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0

Commit: aa0cfbd19c185119571e35291be38f270b847ae8
Author: Ivan Suzdal <email address hidden>
Date: Fri Jun 3 12:51:37 2016

Wait for socket ready in libvirtd upstart job.

Upstart job switch state to running before
libvirtd socket is created.
Patch backported from upstream (LP: #1455608, LP: #1571209).

Cherry-picked from https://review.fuel-infra.org/#/c/21560

Change-Id: Iba72a6e8b570a0d834ab7393390b9b528c0160d4
Related-Bug: #1583183

[Sergey Novikov (snovikov)]

Verified on mos 9.0 iso #449