[Vbox] Clean networks always before launching

[Fabrizio Soppelsa]

Ensure that https://github.com/openstack/fuel-main/blob/master/virtualbox/functions/network.sh#L192 is called always during new setups, even if the script crashed or was stopped by user, to prevent network mess.

Observed in Win7, attached screen.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/266934

[Serhii Ovsianikov (sovsianikov)]

If user wants to remove all hostonly network interfaces he can change this variable https://github.com/openstack/fuel-main/blob/2bb999e220d3e84f50cc6e3378979c331ec9c289/virtualbox/config.sh#L35

There is a bug https://bugs.launchpad.net/fuel/+bug/1384976 where were deleted all hostonly network interfaces.

By default vbox scripts should not break anything.

[Maksim Malchuk (mmalchuk)]

Right now we don't have a support of renaming network interfaces under Windows OS, so in the case of a failure we not able to identify and remove correct interfaces.

So if you want the old behavior feel free to change the configuration on your own. From now, by default, we should do full cleanup before create the new interfaces.

This problem described in the more recent bug: https://bugs.launchpad.net/fuel/+bug/1524558 !

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/266934
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=7b6c10e99ca8452bf54bcb7f27ad18fc59826334
Submitter: Jenkins
Branch: master

commit 7b6c10e99ca8452bf54bcb7f27ad18fc59826334
Author: Maksim Malchuk <email address hidden>
Date: Tue Dec 29 21:06:32 2015 +0300

    Proper Windows 7/8/10 support

    This commit adds enchantments and proper support for Windows 7/8/10:
     * more verbose messages.
     * by default all network interfaces will be removed.
     * some code cleanup and regexp fixes.
     * added sleeps for some network operations.
     * proper support for windows full filenames.

    Change-Id: Ic56f8d114bdaf83dd12b76dd6cc46eaa8d74da52
    Closes-Bug: #1524558
    Closes-Bug: #1496042

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/268058

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/268058
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=406aa4219ed89d231bbd26349adfc15dbcc10125
Submitter: Jenkins
Branch: stable/8.0

commit 406aa4219ed89d231bbd26349adfc15dbcc10125
Author: Maksim Malchuk <email address hidden>
Date: Tue Dec 29 21:06:32 2015 +0300

    Proper Windows 7/8/10 support

    This commit adds enchantments and proper support for Windows 7/8/10:
     * more verbose messages.
     * by default all network interfaces will be removed.
     * some code cleanup and regexp fixes.
     * added sleeps for some network operations.
     * proper support for windows full filenames.

    Change-Id: Ic56f8d114bdaf83dd12b76dd6cc46eaa8d74da52
    (cherry-picked from 78aa1e59c558e890659e0187c909f8445bca34e9)
    Closes-Bug: #1524558
    Closes-Bug: #1496042

[ElenaRossokhina (esolomina)]

Verified on Win7, iso#529 and virtualbox
network i/faces are deleted during install procedure