new OpenStack configuration didn't apply

[Ksenia Svechnikova]

ISO 239

https://paste.mirantis.net/show/1504/

Steps:

Deploy cluster with 3+2 node

1) Upload file with configuration

keystone.yaml
---
configuration:
  keystone_config:
    ldap/url:
      value: ldap://dc.example.com
    ldap/user:
      value: CN=ldap,OU=Users,DC=example,DC=com
    ldap/password:
      value: ldap_test
    ldap/suffix:
      value: DC=example,DC=com
    ldap/use_dumb_member:
      value: True
    ldap/dumb_member:
      value: CN=ldap,OU=Users,DC=example,DC=com
    ldap/user_tree_dn:
      value: OU=Users,DC=example,DC=com
    ldap/user_objectclass:
      value: person
    ldap/user_filter:
      ensure: absent
    ldap/user_id_attribute:
      value: cn
    ldap/user_name_attribute:
      value: cn
    ldap/user_mail_attribute:
      value: mail
    ldap/user_pass_attribute:
      ensure: absent
    ldap/user_enabled_attribute:
      value: userAccountControl
    ldap/user_enabled_mask:
      value: 2
    ldap/user_enabled_default:
      value: 512
    ldap/user_attribute_ignore:
      value: password,tenant_id,tenants
    ldap/user_allow_create:
      value: False
    ldap/user_allow_update:
      value: False
    ldap/user_allow_delete:
      value: False
    ldap/role_tree_dn:
      value: OU=Roles,DC=example,DC=com
    ldap/role_filter:
      ensure: absent
    ldap/role_objectclass:
      value: organizationalRole
    ldap/role_id_attribute:
      value: cn
    ldap/role_name_attribute:
      value: ou
    ldap/role_name_attribute:
      value: roleOccupant
    ldap/role_attribute_ignore:
      ensure: absent
    ldap/role_allow_create:
      value: True
    ldap/role_allow_create:
      value: True
    ldap/role_allow_create:
      value: True
    identity/driver:
      value: keystone.identity.backends.ldap.Identity

fuel openstack-config --upload --env 1 --node 1 --file keystone.yaml

2) Apply new settings to the controller:

fuel --debug openstack-config --execute --env 1 --node 1

Actual results:

1) The new task is marked as ready(task 14):

[root@nailgun ~]# fuel task
id | status | name | cluster | progress | uuid
---|--------|-------------------------|---------|----------|-------------------------------------
3 | ready | check_networks | 1 | 100 | 4dbc2ecf-d3cc-4846-b2f4-2aaf8fc98926
2 | ready | deploy | 1 | 100 | e4b8966c-1e7e-4e67-91cf-3901fd9a4d5b
6 | ready | provision | 1 | 100 | 6424a3e8-36c6-4843-9bca-c34bce422d2f
15 | ready | dump | None | 100 | 6e9b3b90-cee3-4735-bf2e-c9904b94a3f0
9 | ready | check_dhcp | 1 | 100 | 25765420-f2e8-48d5-953f-529eaee868be
10 | ready | check_repo_availability | 1 | 100 | 1b06fed9-23d1-4ba3-bbdf-cb3581e673a5
8 | ready | verify_networks | 1 | 100 | 74a0d732-8e8d-470a-81fd-74a9ee5a495c
14 | ready | deployment | 1 | 100 | 74b3b57f-b3fd-4c31-a8d0-ad6650258dca

2) The file with configuration exist on the node at /etc/hiera/override/configuration/node-1.test.domain.local.yaml
3) Puppet was not apply, /etc/keystone/keystone.conf was not changed

Expected results:

1) New task finished
2) keystone configuration was changed in the node
3) keystone service was restarted

[Alexander Saprykin (cutwater)]

Deploying environment to reproduce the issue

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/252437

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/252463

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexander Saprykin (<email address hidden>) on branch: master
Review: https://review.openstack.org/252437
Reason: Replaced with https://bugs.launchpad.net/fuel/+bug/1521929

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/252472

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/252463
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=adb0b1359d162b0a233b41e993306eb87a7627db
Submitter: Jenkins
Branch: master

commit adb0b1359d162b0a233b41e993306eb87a7627db
Author: Alexander Saprykin <email address hidden>
Date: Wed Dec 2 16:39:33 2015 +0100

    Fix deployment task serialization on config execute

    Change-Id: I19aef6d6d1fe6578bdf8fd65ea96257033804011
    Partial-Bug: #1521929

[Ihor Kalnytskyi (ikalnytskyi)]

It's not critical bug at all. Moreover, I'd argue about high prio.

For now, I assign High prio, but taking into account that it doesn't affect deployment functionality and workload - I'd agree on medium.

[Ksenia Svechnikova (kdemina)]

Yes, it doesn't affect deployment

But it do affect the core functionality of the feature. As a result majority of the acceptance tests for it are blocked and new system tests couldn't be added. Doesn't it permit us to return the Importance?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/252472
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c12005537a38f2d4ae919b6da81f0abc9fbeca23
Submitter: Jenkins
Branch: master

commit c12005537a38f2d4ae919b6da81f0abc9fbeca23
Author: Alexander Saprykin <email address hidden>
Date: Wed Dec 2 16:52:15 2015 +0100

    Serialize cwd in generic task parameters

    Astute requires "cwd" task parameter to be
    present for certain puppet tasks.
    It causes a failure when puppet task is
    serialized by generic serializer.

    Change-Id: I6c95f99ef2e6079015677c4b937c4e031a0f0809
    Partial-Bug: #1521929

[Ksenia Svechnikova (kdemina)]

ISO#268

Verify cases "Reconfigure nova CPU overcommit ratio" and "Reconfigure keystone to use LDAP" from BP:https://blueprints.launchpad.net/fuel/+spec/test-openstack-config-change