commit ac715526ff82d8a36dab4a724b371f628887aad2
Author: Alex Schultz <email address hidden>
Date: Thu Oct 22 14:53:49 2015 -0500
Fix tests for l23network
This change includes an update to rspec-puppet ~> 2.2 and adjusting the
two tests that fail under 2.2 but not 2.1. I believe these failures are
related to https://github.com/rodjek/rspec-puppet/issues/266
The get_network_role_properly was previously passing because the return
value was not be properly check. In the code we are returning eth0 as
the interface for the admin network role and not nil.
The get_transformation_property was previously passing because the
return value was not correctly checked. Based on the code, the value for
eth2 should have been 1024 while the value for eth3 would have been nil.
This change updates the eth2 check with 1024 and adds a test case for
eth3.
Reviewed: https:/ /review. openstack. org/238680 /git.openstack. org/cgit/ openstack/ fuel-library/ commit/ ?id=ac715526ff8 2d8a36dab4a724b 371f628887aad2
Committed: https:/
Submitter: Jenkins
Branch: master
commit ac715526ff82d8a 36dab4a724b371f 628887aad2
Author: Alex Schultz <email address hidden>
Date: Thu Oct 22 14:53:49 2015 -0500
Fix tests for l23network
This change includes an update to rspec-puppet ~> 2.2 and adjusting the /github. com/rodjek/ rspec-puppet/ issues/ 266
two tests that fail under 2.2 but not 2.1. I believe these failures are
related to https:/
The get_network_ role_properly was previously passing because the return
value was not be properly check. In the code we are returning eth0 as
the interface for the admin network role and not nil.
The get_transformat ion_property was previously passing because the
return value was not correctly checked. Based on the code, the value for
eth2 should have been 1024 while the value for eth3 would have been nil.
This change updates the eth2 check with 1024 and adds a test case for
eth3.
Change-Id: I7b87d02d4c702d de68ecd7f4abcd3 04e686fa795
Closes-Bug: #1509056