Incorrect usage of arguments in network/manager.py leads to strage errors under some conditions

Bug #1483709 reported by Przemyslaw Kaminski on 2015-08-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Alexander Kislitsky

Bug Description

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/manager.py#L770

We pass node.id there but _get_admin_network_node expects 'node'. In that function we call https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/manager.py#L713 which uses node.full_name (see https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/manager.py#L1047).

It seems that test cases never reach https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/manager.py#L1055 which would happily throw exception.

This code needs to be carefully analyzed and fixed, it is unacceptable to have such things on production.

Ihor Kalnytskyi (ikalnytskyi) wrote :

Why it's critical? It looks medium to me. Anyway, I propose to move it to 8.0.

Changed in fuel:
milestone: 7.0 → 8.0
importance: Critical → High
status: New → Confirmed
Przemyslaw Kaminski (pkaminski) wrote :

This code is broken. Arguments are passed incorrectly. Logging throws exceptions. For me this is critical.

Ihor Kalnytskyi (ikalnytskyi) wrote :

@Przemyslaw,

I'm sorry. I think I can't get what's wrong. It looks to me that there's no understanding what's wrong, only assumption. I can agree that if something strange is happened.. perhaps it should be rewritten in a safe way or removed it at all if it's legacy. Still, it could be done in next release, imo. If you got some time to fix it in 7.0 - let's go on, but let's do not spend much time pursuing shadow bugs.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Przemyslaw Kaminski (pkaminski)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/211480
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=c7fb4f4557b1c5c854248ecf2ccfa9d57e756ea8
Submitter: Jenkins
Branch: master

commit c7fb4f4557b1c5c854248ecf2ccfa9d57e756ea8
Author: Przemyslaw Kaminski <email address hidden>
Date: Tue Aug 11 11:40:40 2015 +0200

    Validate network settings data first

    Change-Id: Ib89e5310f0d85b48fdaa811acb3997727976b7d8
    Partial-Bug: #1483709
    Closes-Bug: #1483240

Changed in fuel:
assignee: Przemyslaw Kaminski (pkaminski) → Fuel Python Team (fuel-python)
Dmitry Pyzhov (dpyzhov) on 2015-09-18
Changed in fuel:
status: In Progress → Confirmed
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Alexander Kislitsky (akislitsky)

@Przemyslaw, seems, that code of network/manager.py has been changed and line numbers from the description don't describe the issue any more. Could you please clarify items of the issue to be fixed.
Moving status to Incomplete.

Changed in fuel:
status: Confirmed → Incomplete

I've checked code in master on 2015-08-11, compared with the current one. Scope of this bug is unclear. Moving but to Invalid.

Changed in fuel:
status: Incomplete → Invalid
Dmitry Pyzhov (dpyzhov) on 2015-10-22
tags: added: area-python
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers