Comment 6 for bug 1458619

Revision history for this message
Artem Roma (aroma-x) wrote :

Igor, to be honest I don't think the patch is silver bullet here. Down to final version the code only checks that suite name doesn't contain backward slashes in it in case when 'casual' way of repository description is used. It is so particular case for amount of code being introduced. Continuing, if we add possibility to deploy CentOS nodes, in that case user may also be able to supply custom rpm repos. Those also should be validated which means - sticking to logic of my changes - adding more small specific checks. IMO that looks like simply not right approach. Besides, as I've mentioned in my previous comment, user also might make mistakes in other parts of description - sections names, type of repository (considering apt format). What I have in mind is separate check that will perform some "real life" interaction with particular repository (e.g. `apt-get update` operation). Hence test will be more general and effective, and we can drop all intermediate validation. This pretty rough description of the idea though, so I would gladly hear other opinions about the matter.