Comment 19 for bug 1396481

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/138415
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=2eaba85606656149db68c86cbe9b5dc9bf471d6f
Submitter: Jenkins
Branch: master

commit 2eaba85606656149db68c86cbe9b5dc9bf471d6f
Author: Vladimir Kuklin <email address hidden>
Date: Tue Dec 2 18:51:28 2014 +0300

    Fix apply_changes function race condition

    Due to an error in logic of apply_changes method
    we had problems with parallel deployment of controllers
    as we were generating XML patch between live CIB and
    shadow generated on the base of (sometimes!) older CIB.

    This could lead to the problem that crm_diff removes
    some of the data from the live CIB as it was not present
    in the old CIB.

    An example of such behaviour is the bug with location
    constraints missing for virtual ip addresses as our
    service provider was creating them in this window
    between shadow creation and retrieving of the live CIB
    thus crm_diff was generating patch removing this location
    and leading to this bug.

    Change-Id: Icb28fe6d90f44084d424b793db792869e0c6c66c
    Closes-bug: #1396481