Extend nailgun check_network to verify that we have correct numbers of ips in range

[Gil Meir]

When installing CentOS HA I defined a pool of IP addresses for the public network, amount equal to the number of nodes. Since there should be another address in the pool (note: not-intuitive), when pressing "Deploy changes" I got an error "not enough IP addresses in the pool".
The bug is that at this step all the configuration fields became disabled, and there is no way to edit / add IP addresses.
Validation should be done when pressing "Save settings", not "Deploy changes".

* This might be similar to this bug in the concept, but still a different bug: https://bugs.launchpad.net/fuel/+bug/1353391

{"build_id": "2014-08-06_11-23-14", "ostf_sha": "be71965998364bf8e6415bd38b75c84b63aab867", "build_number": "406", "auth_required": true, "api": "1.0", "nailgun_sha": "f64b06c788e2b92fcb8e678ea6d0c9b86e8d0ab7", "production": "docker", "fuelmain_sha": "124ea87f1ac1c06e27613fe3b31fd5fc6b39e82d", "astute_sha": "99a790ad1b7526cbbd5bf8add0cb2b4e503fccd4", "feature_groups": ["mirantis"], "release": "5.1", "fuellib_sha": "513ec5cdcdef74c7419d5bae967b9edc7da8dbd7"}

[Dima Shulyak (dshulyak)]

I think we have blueprint somewhere to allocate ip addresses before deployment.
Maybe we can squeeze atleast some basic validation in 5.1 ?

[Dima Shulyak (dshulyak)]

Looks like we dont have time to add such validation in 5.1, so i will set medium priority and postpone to 6.0

[Aleksey Kasatkin (alekseyk-ru)]

Actually, we need to add such checks for all networks. And it should encounter VIPs for Public and Management. It should take into account node groups also.

[Aleksey Kasatkin (alekseyk-ru)]

Validation issue. Does not break deployment. Tech debt. Moved to 8.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/245941

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/245941
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4e2d655555e56b730ddd98504d371f85eaa5a0b2
Submitter: Jenkins
Branch: master

commit 4e2d655555e56b730ddd98504d371f85eaa5a0b2
Author: Bulat Gaifullin <email address hidden>
Date: Mon Nov 16 22:38:53 2015 +0300

    prepare_for_deployment was moved to network manager

    The network related function shall be in NetworkManager,
    this makes easier further refactoring.

    Change-Id: I8eb5404509c9fe0a8c367ea119bfb18233941fde
    Partial-Bug: #1354803

[Nikita Zubkov (zubchick)]

Looks like it's not a high bug, after clicking deployment we still have an error, but network tab is not locked.

[Nikita Zubkov (zubchick)]

As I said now it's not an issue and you can easily change network settings after getting this error. So won't fix.