nsx-v plugin v1.1.0 problems with hiera overrides

[Nikita Koshikov]

When using nsx-v plugin with others plugins that adds values inside quantum_settings hash - the deployment fails with:
$quantum_settings is :undef, not a hash or array at puppet/modules/nsxv/manifests/init.pp:14

Steps to reproduce:
1)create hiera override file with content:
quantum_settings:
 keystone:
   admin_password: 'passwd'

2)Try to run nsxv-install task
cd /etc/fuel/plguins/nsxv-1.0/
puppet apply --debug --modulepath:'puppet/modules:/etc/puppet/modules' puppet/manifests/nsxv-config.pp

fix is pretty simple - change hiera to hiera_hash

deployment_scripts/puppet/modules/nsxv/manifests/init.pp
- $quantum_settings = hiera('quantum_settings')
+ $quantum_settings = hiera_hash('quantum_settings')

deployment_scripts/puppet/modules/nsxv/files/openstack-network-controller.pp
- $ceilometer_hash = hiera('ceilometer',{})
+ $ceilometer_hash = hiera_hash('ceilometer',{})

This is MOS 7.0 and plugin version: 1.1.0

[Igor Zinovik (izinovik)]

Proposed change:
https://review.openstack.org/259435

[Artem Savinov (asavinov)]

If you create hiera override file with content(with highest priority in hiera):

quantum_settings:
 keystone:
   admin_password: 'passwd'

you get error in top-role-compute task(uses for compute/compute-vmware roles)

Error: $neutron_config["database"] is :undef, not a hash or array at /etc/puppet/modules/osnailyfacter/modular/roles/compute.pp:97

https://github.com/openstack/fuel-library/blob/stable/7.0/deployment/puppet/osnailyfacter/modular/roles/compute.pp#L96
(this fix in master branch)

[Nikita Koshikov (nkoshikov)]

@asavinov this is know bug - https://bugs.launchpad.net/fuel/+bug/1504070