compute doesn't support override settings for quantum_settings.

[Nikita Koshikov]

In 7.0 if I override part of quantum_settings for hiera, like here:
/etc/hiera/override/openstack-region.yaml
region: region_eu
nova:
  region: region_eu
quantum_settings:
  region: region_eu

Deployment fails with:
Debug: hiera(): Found quantum_settings in override/openstack-region
Error: $neutron_config["database"] is :undef, not a hash or array at /etc/puppet/modules/osnailyfacter/modular/roles/compute.pp:97 on node node-4.test.domain.local
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/leaf.rb:139:in `evaluate_container'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/leaf.rb:155:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:62:in `safeevaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/vardef.rb:14:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:62:in `safeevaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:15:in `block in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `each'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:62:in `safeevaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/ifstatement.rb:25:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:62:in `safeevaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:15:in `block in evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `each'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast/block_expression.rb:10:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/ast.rb:62:in `safeevaluate'
/usr/lib/ruby/vendor_ruby/puppet/resource/type.rb:121:in `evaluate_code'
/usr/lib/ruby/vendor_ruby/puppet/parser/resource.rb:79:in `evaluate'
/usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:366:in `evaluate_main'
/usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:110:in `block in compile'
/usr/lib/ruby/vendor_ruby/puppet/util/profiler/none.rb:6:in `profile'
/usr/lib/ruby/vendor_ruby/puppet/util/profiler.rb:31:in `profile'
/usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:110:in `compile'
/usr/lib/ruby/vendor_ruby/puppet/parser/compiler.rb:23:in `compile'
/usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:116:in `block (2 levels) in compile'
/usr/lib/ruby/vendor_ruby/puppet/util/profiler/none.rb:6:in `profile'
/usr/lib/ruby/vendor_ruby/puppet/util/profiler.rb:31:in `profile'
/usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:114:in `block in compile'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:161:in `block in benchmark'
/usr/lib/ruby/1.9.1/benchmark.rb:295:in `realtime'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:160:in `benchmark'
/usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:113:in `compile'
/usr/lib/ruby/vendor_ruby/puppet/indirector/catalog/compiler.rb:46:in `find'
/usr/lib/ruby/vendor_ruby/puppet/indirector/indirection.rb:201:in `find'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:204:in `main'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:146:in `run_command'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `block (2 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:470:in `plugin_hook'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `block in run'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:478:in `exit_on_fail'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:137:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:91:in `execute'
/usr/bin/puppet:4:in `<main>'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/232460

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/232460
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=52bbd687efb0c8a9e38f1ea4fcfb1279230b8d3b
Submitter: Jenkins
Branch: master

commit 52bbd687efb0c8a9e38f1ea4fcfb1279230b8d3b
Author: Nikita Koshikov <email address hidden>
Date: Thu Oct 8 13:42:49 2015 +0300

    Allow quantum_settings hiera override for compute

     Plus additional style fixes

    Change-Id: I5487441d3aec4446490bc67e8070b9c04fc4c423
    Closes-bug: #1504070

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/232961

[Vitaly Sedelnik (vsedelnik)]

Please don't target to 7.0-mu-1 milestone on your own, QA confirmation is needed to include the bug into the scope of 7.0 MU 1. I retargeted it to 7.0-updates

[Sergey Novikov (snovikov)]

Verified on MOS 8.0 RC#1

STV:

1. Deploy cluster with controller and compute nodes
2. Go to compute node
3. Add /etc/hiera/override/openstack-region.yaml with content:
region: region_eu
nova:
  region: region_eu
quantum_settings:
  region: region_eu
4. Add "override/openstack-region" in /etc/hiera.yaml
5. execute
# puppet apply /etc/puppet/modules/osnailyfacter/modular/roles/compute.pp

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/232961