Comment 9 for bug 1035343

Revision history for this message
Dr. Tilmann Bubeck (t-bubeck) wrote :

I made all requested changes and uploaded the attached patch which is based on lp:~rozzin/foxtrotgps/route-planning.cleanup

* All known memory leaks are fixed.
* gtk_file_chooser_set_current_folder was not needed and is removed now
* waypoints/trackpoints/routepoints? Well, I think we are planing a route consisting of routepoints (rtept). However, some
  web pages speak of routes consisting of waypoints, so I think this is not very clear by definition. Regardless of what we
  write into our generated GPX files we are able to read "rtept" and also "waypt", but not "trackpt" which is for tracking
  a route which you already travelled. So I did not change anything, because I do think that it is consistent. If you disagree,
  feel free to change in any way.
* hardcoded timestamp is now created dynamically.

In addition I reordered the entries of the "route & wp" menu. I moved all entries dealing with single points at the top of the menu and all entries dealing with all waypoints (=routes) to the end.

So I would consider this patch as final and would appreciate inclusion very much.