Comment 8 for bug 1035343

"Dr. Tilmann Bubeck" <email address hidden> writes:
>
> Thanks for your valuable feedback. I have no problems with:
> - fixing memory leaks
> - commented-out call
> - timestamp
>
> But I do not know, how to split the changes in some other direction
> (refactor first, then change). You already improved my patch (Thanks!)
> but how should I now reorder the changes? This is more a kind of a bzr
> like question.

It is indeed really a bzr question. The useful commands for revising
a series of commits are mainly "uncommit", "shelve", "commit", "unshelve".
It can be really useful to understand how to do to that.

However...:

> What I can do is branch from your repo
> (https://code.launchpad.net/~rozzin/foxtrotgps/route-planning.cleanup)
> and generate a patch of the remaining issues listed above. Is that
> what you wanted?

I think that would actually be fine, yes; the refactoring that you did
here is pretty self-evident, so I can split it out myself without
much difficulty. If you can just fix the remaining few issues,
and supply answers to the questions, that will be great :)

--
"Don't be afraid to ask (λf.((λx.xx) (λr.f(rr))))."