Comment on attachment 600506 Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch)
Review of attachment 600506: -----------------------------------------------------------------
Stealing the review because Chris doesn't have time. Looks fine--just one little note about this and bug 731110 but you probably already know anyway.
::: js/src/Makefile.in @@ +351,5 @@ > + OSAllocatorWin.cpp \ > + PageBlock.cpp \ > + YarrInterpreter.cpp \ > + YarrPattern.cpp \ > + YarrSyntaxChecker.cpp \
This probably conflicts with patch 3 in bug 731110. Not sure exactly how you guys want to deal with that, just pointing it out.
Comment on attachment 600506
Use YARR interpreter instead of PCRE on platforms where YARR JIT is not supported (m-c patch)
Review of attachment 600506: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
Stealing the review because Chris doesn't have time. Looks fine--just one little note about this and bug 731110 but you probably already know anyway.
::: js/src/Makefile.in er.cpp \
@@ +351,5 @@
> + OSAllocatorWin.cpp \
> + PageBlock.cpp \
> + YarrInterpreter.cpp \
> + YarrPattern.cpp \
> + YarrSyntaxCheck
This probably conflicts with patch 3 in bug 731110. Not sure exactly how you guys want to deal with that, just pointing it out.