Comment 25 for bug 857153

Comment on attachment 572602
PATCH

Review of attachment 572602:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +81,4 @@
> #include "nsTextFragment.h"
> #include "mozilla/Services.h"
> #include "nsEventStates.h"
> +#include "prenv.h"

is this needed?

@@ +1833,4 @@
> // Services
> ////////////////////////////////////////////////////////////////////////////////
>
> + mozilla::a11y::FocusManager*

I don't see the need for the indentation. just nitpicking here.

::: widget/src/gtk2/nsWindow.cpp
@@ +1110,4 @@
> }
>
> #ifdef ACCESSIBILITY
> + if (aState && a11y::ShouldA11yBeEnabled())

in nsAccessibilityService.h, ShouldA11yBeEnabled() is declared only we use ATK, while here it seems to be for the ACESSIBILITY.

@@ +6475,4 @@
> void
> nsWindow::DispatchEventToRootAccessible(PRUint32 aEventType)
> {
> + if (!a11y::ShouldA11yBeEnabled())

same as above.