Comment on attachment 542230
Enforce alignment for ARM code in Thumb mode in libvpx
># HG changeset patch
># User Timothy B. Terriberry <email address hidden>
># Date 1309201530 25200
># Node ID 1e745d4b39c8f8d7ffb3d4b8cdd7fafce68c5349
># Parent e338daa71bc2fdb9c05a276ef1a477e1730f0aca
>Bug 666931 - Enforce alignment for ARM code in Thumb mode in libvpx
>
>diff --git a/media/libvpx/build/make/ads2gas.pl b/media/libvpx/build/make/ads2gas.pl
>--- a/media/libvpx/build/make/ads2gas.pl
>+++ b/media/libvpx/build/make/ads2gas.pl
>@@ -74,17 +74,20 @@ while (<STDIN>)
>
> # Convert INCLUDE to .INCLUDE "file"
> s/INCLUDE(\s*)(.*)$/.include $1\"$2\"/;
>
> # Code directive (ARM vs Thumb)
> s/CODE([0-9][0-9])/.code $1/;
>
> # No AREA required
>- s/^\s*AREA.*$/.text/;
>+ # But ALIGNs in AREA must be obeyed
>+ s/^\s*AREA.*ALIGN=([0-9])$/.text\n.p2align $1/;
>+ # If no ALIGN, strip the AREA and align to 4 bytes
>+ s/^\s*AREA.*$/.text\n.p2align 2/;
>
> # DCD to .word
> # This one is for incoming symbols
> s/DCD\s+\|(\w*)\|/.long $1/;
>
> # DCW to .short
> s/DCW\s+\|(\w*)\|/.short $1/;
> s/DCW(.*)/.short $1/;
>diff --git a/media/libvpx/update.sh b/media/libvpx/update.sh
>--- a/media/libvpx/update.sh
>+++ b/media/libvpx/update.sh
>@@ -321,8 +321,11 @@ patch -p3 < solaris.patch
> # Patch to fix link with xcode4
> patch -p1 < xcode4.patch
>
> # Patch to fix data race on global function pointers
> patch -p3 < bug640935.patch
>
> # Patch to avoid text relocations on ARM
> patch -p3 < bug646815.patch
>+
>+# Patch to fix alignment problems with using ARM asm in Thumb mode.
>+patch -p3 < bug666931.patch
Title:
Firefox crashes when attempting to play webm video on ARM with Thumb2
enabled
Status in binutils:
Fix Released
Status in The Mozilla Firefox Browser:
Fix Released
Status in Linaro Ubuntu Evaluation Builds:
Fix Released
Status in “binutils” package in Ubuntu:
New
Status in “firefox” package in Ubuntu:
Triaged
Bug description:
Binary package hint: firefox
This bug was discovered on Linaro 11.05 LEB image "ubuntu-desktop"
with "panda" hwpack.
ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: firefox 4.0.1+build1+nobinonly-0ubuntu0.11.04.2
ProcVersionSignature: Ubuntu 2.6.38-1003.4~ppa5-hostname-omap 2.6.38.7
Uname: Linux 2.6.38-1003-linaro-omap armv7l
Architecture: armel
Date: Fri May 27 15:56:39 2011
DistributionChannelDescriptor:
# This is a distribution channel descriptor
# For more information see http://wiki.ubuntu.com/DistributionChannelDescriptor
canonical-oem-linaro-n-ubuntu-desktop-20110526-0
FirefoxPackages:
firefox 4.0.1+build1+nobinonly-0ubuntu0.11.04.2
flashplugin-installer N/A
adobe-flashplugin N/A
icedtea-plugin N/A
ProcEnviron:
LANGUAGE=C:en
LANG=C
SHELL=/bin/bash
SourcePackage: firefox
UpgradeStatus: No upgrade log present (probably fresh install)
T
Sent from my Verizon Wireless BlackBerry
-----Original Message-----
From: derf <email address hidden>
Sender: <email address hidden>
Date: Sun, 03 Jul 2011 19:35:58
To: <email address hidden>
Reply-To: Bug 789198 <email address hidden>
Subject: [Bug 789198]
Comment on attachment 542230
Enforce alignment for ARM code in Thumb mode in libvpx
># HG changeset patch 7ffb3d4b8cdd7fa fce68c5349 9c05a276ef1a477 e1730f0aca libvpx/ build/make/ ads2gas. pl b/media/ libvpx/ build/make/ ads2gas. pl libvpx/ build/make/ ads2gas. pl libvpx/ build/make/ ads2gas. pl \s*)(.* )$/.include $1\"$2\"/; [0-9][0- 9])/.code $1/; *$/.text/ ; *ALIGN= ([0-9]) $/.text\ n.p2align $1/; *$/.text\ n.p2align 2/; \|(\w*) \|/.long $1/; \|(\w*) \|/.short $1/; libvpx/ update. sh b/media/ libvpx/ update. sh libvpx/ update. sh libvpx/ update. sh
># User Timothy B. Terriberry <email address hidden>
># Date 1309201530 25200
># Node ID 1e745d4b39c8f8d
># Parent e338daa71bc2fdb
>Bug 666931 - Enforce alignment for ARM code in Thumb mode in libvpx
>
>diff --git a/media/
>--- a/media/
>+++ b/media/
>@@ -74,17 +74,20 @@ while (<STDIN>)
>
> # Convert INCLUDE to .INCLUDE "file"
> s/INCLUDE(
>
> # Code directive (ARM vs Thumb)
> s/CODE(
>
> # No AREA required
>- s/^\s*AREA.
>+ # But ALIGNs in AREA must be obeyed
>+ s/^\s*AREA.
>+ # If no ALIGN, strip the AREA and align to 4 bytes
>+ s/^\s*AREA.
>
> # DCD to .word
> # This one is for incoming symbols
> s/DCD\s+
>
> # DCW to .short
> s/DCW\s+
> s/DCW(.*)/.short $1/;
>diff --git a/media/
>--- a/media/
>+++ b/media/
>@@ -321,8 +321,11 @@ patch -p3 < solaris.patch
> # Patch to fix link with xcode4
> patch -p1 < xcode4.patch
>
> # Patch to fix data race on global function pointers
> patch -p3 < bug640935.patch
>
> # Patch to avoid text relocations on ARM
> patch -p3 < bug646815.patch
>+
>+# Patch to fix alignment problems with using ARM asm in Thumb mode.
>+patch -p3 < bug666931.patch
-- /bugs.launchpad .net/bugs/ 789198
You received this bug notification because you are subscribed to firefox
in Ubuntu.
https:/
Title:
Firefox crashes when attempting to play webm video on ARM with Thumb2
enabled
Status in binutils:
Fix Released
Status in The Mozilla Firefox Browser:
Fix Released
Status in Linaro Ubuntu Evaluation Builds:
Fix Released
Status in “binutils” package in Ubuntu:
New
Status in “firefox” package in Ubuntu:
Triaged
Bug description:
Binary package hint: firefox
This bug was discovered on Linaro 11.05 LEB image "ubuntu-desktop"
with "panda" hwpack.
ProblemType: Bug nobinonly- 0ubuntu0. 11.04.2 gnature: Ubuntu 2.6.38- 1003.4~ ppa5-hostname- omap 2.6.38.7 1003-linaro- omap armv7l hannelDescripto r: wiki.ubuntu. com/Distributio nChannelDescrip tor oem-linaro- n-ubuntu- desktop- 20110526- 0 nobinonly- 0ubuntu0. 11.04.2 installer N/A flashplugin N/A
DistroRelease: Ubuntu 11.04
Package: firefox 4.0.1+build1+
ProcVersionSi
Uname: Linux 2.6.38-
Architecture: armel
Date: Fri May 27 15:56:39 2011
DistributionC
# This is a distribution channel descriptor
# For more information see http://
canonical-
FirefoxPackages:
firefox 4.0.1+build1+
flashplugin-
adobe-
icedtea-plugin N/A
ProcEnviron:
LANGUAGE=C:en
LANG=C
SHELL=/bin/bash
SourcePackage: firefox
UpgradeStatus: No upgrade log present (probably fresh install)
To manage notifications about this bug go to: /bugs.launchpad .net/binutils/ +bug/789198/ +subscriptions
https:/