Comment 40 for bug 73536

Revision history for this message
In , Benjamin Smedberg (Mozilla) [:bs] (benjamin-smedbergs) wrote :

I am not the right person to review this, having never written anything useful with signal handlers. If I understand this correctly, the signal handler itself is signaling a pipe which wakes up the event loop. Is this because it is not safe to make any GTK calls from within the signal handler? I do think that eForceQuit is correct for SIGTERM, but I wonder if we shouldn't be using eAttemptQuit for SIGQUIT, so that it can properly prompt for unsaved work.