Comment 80 for bug 572074

Revision history for this message
In , Gijskruitbosch+bugs (gijskruitbosch+bugs) wrote :

Comment on attachment 8782846
patch v4

Review of attachment 8782846:
-----------------------------------------------------------------

Meh. r+ I guess? I'm not sure why this is "simpler", but obviously it works, so whatever.

As far as the "window" case is concerned, you're explicitly regressing bug 644186, but you reviewed that and it never had ui-review, so up to you if you think you need it here.

::: browser/base/content/browser.js
@@ -7839,5 @@
> }
> }
> };
>
> -function BrowserOpenNewTabOrWindow(event) {

This method is referenced by a number of add-ons including but not limited to tabmixplus. We probably need to list it in the compat notes.