> There's a short-circuit in nsContentBlocker::ShouldLoad that ensures that!
Yes, and presumably you need to duplicate that here (via code-sharing, not copy-paste).
I have no idea what most of comment 81 is about; maybe gavin does. We do have an effective tld service that feels like it should do what one wants here, but this code doesn't seem to be using it; I have no idea what behavior is expected/desired/etc here.
You might want to get gavin's review before having me look at this again....
> so no need to provide the error handling
Why do you assume there will be no other callers?
> There's a short-circuit in nsContentBlocke r::ShouldLoad that ensures that!
Yes, and presumably you need to duplicate that here (via code-sharing, not copy-paste).
I have no idea what most of comment 81 is about; maybe gavin does. We do have an effective tld service that feels like it should do what one wants here, but this code doesn't seem to be using it; I have no idea what behavior is expected/ desired/ etc here.
You might want to get gavin's review before having me look at this again....