(In reply to comment #13)
> NS_IS_ALPHA uses isalpha, which depends on locale, so may produce some
> surprises.
NS_IS_ALPHA also checks whether the char is ASCII. So, if the result is true, should be ASCII alphabets.
> We also need to be careful about changing event.charCode if there is a Latin
> character is the current group. If Ctrl-/ is a meaningful shortcut, then I
> guess it should be preferred over Ctrl-Q (with Ctrl-Q tried as fallback).
We should not modify charCode. I think Ctrl+'/' should win. Because if Ctrl+'Q' wins, Ctrl+'/' cannot be accessible. Of course, all UI developers should not use non-alphabets and non-numeric keys for shortcut.
I think that win32 build behaves so, perhaps.
We should use same processing on all platforms if we can.
(In reply to comment #13)
> NS_IS_ALPHA uses isalpha, which depends on locale, so may produce some
> surprises.
NS_IS_ALPHA also checks whether the char is ASCII. So, if the result is true, should be ASCII alphabets.
> We also need to be careful about changing event.charCode if there is a Latin
> character is the current group. If Ctrl-/ is a meaningful shortcut, then I
> guess it should be preferred over Ctrl-Q (with Ctrl-Q tried as fallback).
We should not modify charCode. I think Ctrl+'/' should win. Because if Ctrl+'Q' wins, Ctrl+'/' cannot be accessible. Of course, all UI developers should not use non-alphabets and non-numeric keys for shortcut.
I think that win32 build behaves so, perhaps.
We should use same processing on all platforms if we can.