Comment 9 for bug 1796661

Revision history for this message
In , Gijskruitbosch+bugs (gijskruitbosch+bugs) wrote :

(In reply to Troels Liebe Bentsen from comment #2)

> Don't really know if this is the right location:
>
> https://github.com/mozilla/gecko-dev/blob/7ccc9d8b0bd9f879b6f24f15d8416493228697ac/xpcom/io/nsLocalFileUnix.cpp#L1002

So I guess if there's a permission error we should also try copying? The thing is, it seems like permission errors might not necessarily imply that moves will fail but copies will work... OTOH maybe it's worth trying and we could still give up after the copy fails...

Triage suspects the downloads code is probably using OS.File, so moving there first, though it's possible that the XPCOM nsILocalFile unix implementation also needs changing.