Comment 24 for bug 1130857

Revision history for this message
In , Joe-drew (joe-drew) wrote :

Comment on attachment 687479
proposed fix. Detect that this is a PPC and set the BENDIAN then use that when extracting the bits

Review of attachment 687479:
-----------------------------------------------------------------

::: gfx/2d/convolver.cpp
@@ +206,3 @@
> if (has_alpha)
> + accum[3] += cur_filter * source_data_rows[filter_y][byte_offset +
> + A_OFFSET_IDX];

Can you just leave these all on the same line?

@@ +231,5 @@
> //
> // We only need to do this when generating the final output row (here).
> + int max_color_channel = NS_MAX(out_row[byte_offset + R_OFFSET_IDX],
> + NS_MAX(out_row[byte_offset + G_OFFSET_IDX], out_row[byte_offset
> + + B_OFFSET_IDX]));

Same line here too