Comment 2 for bug 425884

Revision history for this message
reacocard (reacocard) wrote :

a few things that should changed in the patch:
- the setting is only loaded once, when the covers system is initialized. you should just re-read it from settings in find_covers and use preferred_names for the default in the call.
- this method doesn't allow for multiple file names to be chosen. many users will have covers with different names (cover, album...) so we need to support multiple choices, just as 0.2.14 did.
- "Favorite filename" is not very descriptive, perhaps something like "Preferred cover filename" would be clearer.

other than that, looks good