Comment 2 for bug 331047

A few things I noticed:

1) You need to re-work your autodetection so that it uses the infrastructure established in xl/hal.py (see the massstorage plugin for an example).

2) You should pass the raw iPod name to the Device __init__ so it can handle name collisions for you (again, see massstorage).

3) I'm not entirely sure it's a good idea to actually unmount the iPod from inside Exaile, since the user might still want to do something with it (like transfer videos or pictures via another program), or the umount could fail unexpectedly causing Exaile to behave unexpectedly as disconnect() failed partway through. Perhaps this would be best left unimplemented for now, and revisited when we get a full device management UI (probably in 0.3.1).

Aside from those issues, the code looks very good.