Comment 11 for bug 135985

Revision history for this message
reacocard (reacocard) wrote :

> As far as I know, Amarok provides auto encoding detection, which proves
> there is acceptable way on such thing, :)

Yes, but it _doesn't_ prove this implementation works fully. As I said, unless you can prove to me that this isn't going to misdetect any currently-working encodings, then I'm not going to commit it.

I understand that it will provide a very good user experience when this works, but if it causes regressions for users whose files ARE correct, then we can't do it. Period. I have get to see any substantial proof that this approach will not cause regressions - screenshots showing that it does work in some cases are not enough.

One additional note - the locale check at the top is a monstrous hack. The same logic should be applied to ALL locales, since with the internet it is not uncommon for people to have files originating from many different countries and we need to make sure it works well in all of them.