Angular Staff Catalog: Error sorting by Hold Status

[Jennifer Pringle]

3.4.1 and 3.5beta

In the angular staff catalogue on the View Holds page the hold Status column is blank. If you look at the holds for the same record in the current catalogue you get "Waiting for Item", "Ready for Pickup", etc. in that column.

I tried sorting the columns, as that sometimes results in missing data appearing, but the column remains blank. If I try to sort by the Status column the gray/blue thinking bar appears and keeps going until you select a different column to sort by or close the tab.

[Bill Erickson (berick)]

Fix for Hold Status display and sorting errors pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1889133-staffcat-hold-status-display

[Galen Charlton (gmc)]

The patch for hopeless holds (bug 1811710) includes an alternative fix for this problem. Bill, do you see any reason not to backport the statusTemplate part of commit 3de863edd92?

[Bill Erickson (berick)]

Hi Galen, no reason not to backport. Both string handling options get the job done.

[Michele Morgan (mmorgan)]

This issue is resolved in 3.6, I'm tempted to mark it Fix Released, but does it still need to be backported to 3.5?

[Gina Monti (gmonti90)]

Hi All,

3.6.5 testing and 3.9

With the patch in place, unfortunately, the error still occurs when sorting by Status in View Holds (Angular).

[Michele Morgan (mmorgan)]

The blank hold status was fixed by bug 1811710. This patch renames the column from "Status" to "Hold Status" and fixes the sorting error:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1889133-fix_error_sorting_by_hold_status

user/mmorgan/lp1889133-fix_error_sorting_by_hold_status

Changing the bug title for clarity.

[Jessica Woolford (jwoolford)]

The fix prevents the error. However, the holds are sorting in numeric order based on the ID of the status instead of alphabetically.

[Katie Greenleaf Martin (kgmspark)]

confirming that this is still an issue for SPARK/PaILS in 3.9.2

[Josh Stompro (u-launchpad-stompro-org)]

We just ran into this in 3.11.0.

It looks like sorting by the ID number was the intention according to this note

+ if (fieldName === 'status_string') {
+ // status_string is a locally derived value which
+ // cannot be server-sorted. Instead, sort by the
+ // status number for consistent sort behavior and to
+ // avoid API explosions
+ fieldName = 'hold_status';
+ }

So maybe this should be pushed through to get the sorting to work at all, and have a new bug to sort by the string value.

Josh

[Terran McCanna (tmccanna)]

I think incremental progress is better than no progress because at least this will group rows of the same status together and it will get rid of the error message.

[Terran McCanna (tmccanna)]

Signed off on Michele's fix and pushed as far back as rel_3_11.

Also created follow up bug at https://bugs.launchpad.net/evergreen/+bug/2051037

[Galen Charlton (gmc)]

Noting that the patch that was just pushed causes a partial regression on bug 1917495 - column settings involving the hold status column would get undone, though saving them again will swap in the new field name.

Would there be an objection to a follow-up that:

- changes the field name back to status_string
- keeps the label change
- and simply marks the column as not sortable for now?

[Terran McCanna (tmccanna)]

Thanks for catching that, Galen. I will work on a fix for that now.

[Terran McCanna (tmccanna)]

Here's another patch doing what Galen said in comment 12. I also made Current Item and Requested Item non-sortable for the time being since they were also throwing ugly errors.

One bit of weirdness - I had to remove [multiSortable]="true" from eg-grid. With that in place, the grid ignored the eg-grid-column [sortable]="false" settings entirely. Is there a better approach that allows multisortable to stay but still disable sorting in specific columns?

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1889133_partial_reversion

[Galen Charlton (gmc)]

I've tested and pushed this follow-up down to rel_3_11, along with a follow-up that answers your question about multiSortable. Thanks, Terran!

[Terran McCanna (tmccanna)]

Ah! Setting multisortable to false in the columns as well as sortable makes sense, thanks Galen!