Bootstrap OPAC: add support for curbside pickup appointments

Bug #1895737 reported by Galen Charlton
48
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.6
Fix Released
Medium
Unassigned

Bug Description

Per bug 1879983, the Bootstrap OPAC should be updated to support the interfaces to allow patrons to manage curbside pickup appointments.

Evergreen master

Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Jason Boyer (jboyer)
Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jason Boyer (jboyer) wrote :

Here's a branch to do this: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads / working/user/jboyer/lp1895737_bootstrap_curbside

Changed in evergreen:
milestone: none → 3.7-beta2
tags: added: pullrequest
Changed in evergreen:
assignee: Jason Boyer (jboyer) → nobody
Revision history for this message
Jennifer Bruch (jbruchpails) wrote :

Tried testing this today on Terran's Server.

Option to Schedule shows as expected once a hold was captured. Go to the Curbside page and it displays.

Got an Internal Server error message when clicking the Check Times button.

Revision history for this message
Jennifer Bruch (jbruchpails) wrote :

Patron info for testing today is :
username 99999336610
password normab1234

Revision history for this message
Terran McCanna (tmccanna) wrote :

Confirmed that it's not working on my Bug Squashing Week server, but it does appear to be working on Jason's pattypan server. I'm currently testing.

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

The functionality works great, but there are a few some small styling / usability issues:

1 - Styling: The fields and buttons are scrunched (technical term) together and could use a little breathing room.

2 - Styling: The date box is unnecessarily wide (at least on my screen) with excess white space between the date and the calendar icon when active, and just a lot of excess white space in the box when inactive. Reducing the white space might help with #1.

3 - Usability: The date box allows you to pick a date in the past - if you submit it, it says that there are no times available and gives you a button to select another date. This isn't critical, but it's a little clunky and it would be nice if it didn't let you select a date in the past to begin with.

4 - Bug: If you do select a date in the past, you end up with two "Select another date" buttons instead of one (see screenshot).

5- Styling: The "Arrival Notes (vehicle description, etc)" column header is very long. Suggest breaking that into two lines or just saying "Arrival Notes" with a little "?" pop-up helper. This should also help with #1.

6 - Usability: After clicking "Alert staff of arrival", the button disappears, but it would be nice if there were some sort of confirmation message.

Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Andrea Neiman (aneiman)
Changed in evergreen:
assignee: nobody → Andrea Neiman (aneiman)
assignee: Andrea Neiman (aneiman) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Removing pullrequest until at least bullet 4 in comment #5 is resolved. As the others are styling issues, they could go into a new bug if needed.

tags: added: needsrepatch
removed: pullrequest
Changed in evergreen:
milestone: 3.7-rc → 3.7.1
tags: added: curbside
Revision history for this message
Jason Boyer (jboyer) wrote :

I've given this another pass at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1895737_bootstrap_curbside2 / working/user/jboyer/lp1895737_bootstrap_curbside2

I've addressed the styling issues by not trying to wedge the tpac version into the boostrap opac as simplistically as I was, so this version also collapses better when used on a mobile device than before. Also I've taken a couple steps to avoid allowing you to choose a date in the past, and there's now a message after clicking the Alert Staff button.

tags: added: pullrequest
removed: needsrepatch
Changed in evergreen:
milestone: 3.7.1 → 3.7.2
Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_7, and rel_3_6. Thanks, Jason and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.