Precat owning library should not be editable

[Elaine Hardy]

In the XUL client, the owning library for the precat record(s) was not editable by library staff. In the web client, the owning library can be edited by library cataloging staff within item status. This creates a number of issues with the individual item records including transit, checkin, and processing problems.

The owning library (which in PINES case is the consortium (PINES) should not be editable by library staff.

[Chris Sharp (chrissharp123)]

Branch that works for me in testing here for review: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1849334_protect_precat_volume

[Ruth Frasur Davis (redavis)]

I've tested this and consent to signing off on it with my name, Ruth Frasur (rfrasur) and email (<email address hidden>).

[Jane Sandberg (sandbergja)]

Thanks for the branch, Chris! It does work in preventing staff from editing the precat owning library. However, there is a confusing feature in the UI: when staff attempt to modify the precat details in Item Status, they get the "Item(s) successfully modified toast", even though the items were not modified.

I wonder if the Perl code could throw an event if a staff member tries to edit an item with a call number with ID < 1, and then we could teach the AngularJS holdings editor to respect that event before sending the Broadcast channel (or it could send a failure notice along through the broadcast channel?). But that could also be split apart into its own separate bug.

[Jennifer Pringle (jpringle-u)]

Confirmed this is still an issue in 3.7

[Bill Erickson (berick)]

+1 to having the API enforce the policy. Removing pullrequest pending consensus.

[Elaine Hardy (ehardy)]

I am going to file another bug report as soon as I know more but it is also possible to merge the precat record with another bib record. One of our cataloger just did it. Chris was able to restore it.

[Elaine Hardy (ehardy)]

Well, that's embarrassing. Not only is there a bug for the merging precats, I tested and signed off on it. https://bugs.launchpad.net/evergreen/+bug/827356.