Circulation limit set test is not accounting for lost/longoverdue and paid items

[Chris Sharp]

Found in PINES production: When a patron tries to check out items that belong to a limit set (e.g. DVDs in our case), the action.item_user_circ_test() function checks to see if the patron already has the maximum number of items out within the limit set. If the patron has lost or longoverdue items and has paid for those items, the current check doesn't know about that and considers the circulation "active". Adding a check to see if the circulation is closed (action.circulation.xact_finish) fixes the problem.

Branch on the way.

Evergreen 3.0.2
OpenSRF 3.0.0
PostgreSQL 9.5
Ubuntu 16.04 LTS

[Chris Sharp (chrissharp123)]

Here ya go:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1747542_fix_item_user_circ_test_lost_longoverdue_paid

[Jason Stephenson (jstephenson)]

I'm really going to test it this time, I promise. :)

[Jason Stephenson (jstephenson)]

Looks like we're using LOST and not LONGOVERDUE, so there's no way for us to really test this.

[Galen Charlton (gmc)]

Works for me. Signoff branch is working/user/gmcharlt/lp1747542_signoff.

[Jason Boyer (jboyer)]

Pushed to rel_3_4, rel_3_5, and master. Thanks Chris and Galen!