input fields in the public catalog often have no description

[Jane Sandberg]

Most types of <input> tags must have some explicit description in order to meet accessibility standards like WCAG. This can be accomplished with a corresponding <label> tag, and there are several other options when the <label> tag isn't appropriate (here's a good overview: https://webaim.org/techniques/forms/advanced).

[Jane Sandberg (sandbergja)]

Related bug in the Web client: https://bugs.launchpad.net/evergreen/+bug/1615800

[Jane Sandberg (sandbergja)]

Started a branch to take care of this here: user/sandbergja/lp1735768_add_labels_to_opac_inputs

Here's the link: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1735768_add_labels_to_opac_inputs

I'm pretty sure there are more out there that need to be fixed, so this branch is not yet ready for the pullrequest tag.

[Jane Sandberg (sandbergja)]

Force-pushed some more changes.

Note that I am using aria-label in some cases, rather than the title attribute. This is despite the work done on this branch: https://bugs.launchpad.net/evergreen/+bug/1301599

This is because of the inconsistent behavior of screen-readers toward the title attribute (I know it's getting better, but it still seems like Chromevox disregards title attributes on <select> tags, even when Chrome uses that title attribute as the <select>'s name in the accessibility API).

[Galen Charlton (gmc)]

Works for me. Signoff branch is user/gmcharlt/lp1735768_signoff.

[Galen Charlton (gmc)]

Pushed to master, rel_3_3, and rel_3_2 (it didn't apply cleanly to rel_3_1). Thanks, Jane!

[Galen Charlton (gmc)]

Fixed this bug's status; fixes were released a while back.