TPAC accessibility (WCAG) improvements: Round 2

[Bill Erickson]

Evergreen 2.6

There are still a few miscellaneous accessibility improvements we can make to the TPAC. There are a few missing labels, some tables that need <th>'s or role="presentation" attributes, depending on its use as a data table vs layout, and possibly some missing submit options (pending research). More details and code to follow.

---

Related, we use aria-labels a good bit in the TPAC. It's my understanding that aria-label's should only be used when existing HTML constructs do not suffice. For reference:

http://www.w3.org/TR/2013/WD-aria-in-html-20131003/#first-rule-of-aria-use

"If you can use a native HTML element [HTML5] or attribute with the semantics and behaviour you require already built in, instead of re-purposing an element and adding an ARIA role, state or property to make it accessible, then do so."

I'm thinking that most of our aria-labels could be replaced with title attributes. If there are no objections, I can make those changes while I'm in the code.

[Bill Erickson (berick)]

Branch in progress:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/tpac-wcag-improvements-part2-lp1301599

[Ben Shum (bshum)]

Looks reasonable so far, the only thing I noticed is that the commit to change some of the aria label to title also left duplicate title entries alongside them. Probably just a bad copy/replace going on there.

[Bill Erickson (berick)]

Thanks, Ben. Looking at those now...

[Bill Erickson (berick)]

I found one occurrence of repeating title attributes in prefs_base.tt2. Rebased working code to master and fix pushed back to the same branch.

[Bill Erickson (berick)]

Fix for one more dupe force-pushed.

[Ben Shum (bshum)]

Everything looks fine, the last thing I'm unsure about is backporting when there are string changes. Like the commit to change the language from "Image of item" to "Book cover". Two issues with that in that backporting a string change to a release branch is generally bad form (or so I was told for i18n reasons), and also I'm not 100% sure I agree with the change in language. While many items are books, not all of them are, so leaving it general as "item" still seems most appropriate to me.

Thoughts or opinions before moving forward?

[Bill Erickson (berick)]

Hmm, yeah... So, the thought was that "item" was so generic it was of little use to screen readers. It's one step above "thing"... Maybe "Image of Record"? The gold standard would be "Image of 'Sisterhood of the Traveling Pants II : Now More Pants!", but given that the alt text displays when no image is available, such a long string of text would break the structure of the page.

For back-porting, we could merge all but the jacket image change. It's the least significant change in the bunch.

Thanks for reviewing, Ben.

[Ben Shum (bshum)]

Picked changes to master and rel_2_6, though I did skip the language change for book cover from rel_2_6.

Thanks Bill!