Not really -- it's not a new feature or enhancement, and the bugfix
won't require any special action to make use of.
> How about tests? I only have a little experience with the PGtap tests
> which wouldn't help with this fix. Are there any current test for the
> hold targeting that could be expanded to have proximities above 9 to
> test for this situation in the future. If someone could give me some
> pointers I'll look into it.
Alas, no. The hold targeter could definitely stand to have some test
cover under src/perlmods/live_t, but for the purpose of your patch, I
think it suffices to write some detailed testing notes for the commit
message.
Regards,
Galen
--
Galen Charlton
Infrastructure and Added Services Manager
Equinox Software, Inc. / The Open Source Experts
email: <email address hidden>
direct: +1 770-709-5581
cell: +1 404-984-4366
skype: gmcharlt
web: http://www.esilibrary.com/
Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
> Does this need release notes?
Not really -- it's not a new feature or enhancement, and the bugfix
won't require any special action to make use of.
> How about tests? I only have a little experience with the PGtap tests
> which wouldn't help with this fix. Are there any current test for the
> hold targeting that could be expanded to have proximities above 9 to
> test for this situation in the future. If someone could give me some
> pointers I'll look into it.
Alas, no. The hold targeter could definitely stand to have some test live_t, but for the purpose of your patch, I
cover under src/perlmods/
think it suffices to write some detailed testing notes for the commit
message.
Regards,
Galen www.esilibrary. com/ koha-community. org & evergreen- ils.org
--
Galen Charlton
Infrastructure and Added Services Manager
Equinox Software, Inc. / The Open Source Experts
email: <email address hidden>
direct: +1 770-709-5581
cell: +1 404-984-4366
skype: gmcharlt
web: http://
Supporting Koha and Evergreen: http://
http://