Evergreen

  1. Series 2.8
  2. Bug #1511828
  3. Comment #6

Comment 6 for bug 1511828

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Thanks Bill, I'll add that change also.

I would like to track down some of the other warnings that pop up when targeting also, I'm not sure I'll have a chance here though.

There are a few that come up when there are no holdable copies.

I don' t understand why this code even needs to be called at all if there are no holdable copies to get the minimum proximity of.

osrfsys.log:[2015-11-01 11:15:02] open-ils.storage [WARN:449:Application.pm:590:] open-ils.storage.action.hold_request.copy_targeter: Use of uninitialized value $min_prox in delete at /usr/local/share/perl/5.14.2/OpenILS/Application/Storage/Publisher/action.pm line 1441.

osrfsys.log:[2015-11-01 11:15:02] open-ils.storage [WARN:449:Application.pm:590:] open-ils.storage.action.hold_request.copy_targeter: Use of uninitialized value $min_prox in anonymous hash ({}) at /usr/local/share/perl/5.14.2/OpenILS/Application/Storage/Publisher/action.pm line 1441.

osrfsys.log:[2015-11-01 11:15:02] open-ils.storage [WARN:449:Application.pm:590:] open-ils.storage.action.hold_request.copy_targeter: Argument "" isn't numeric in sort at /usr/local/share/perl/5.14.2/OpenILS/Application/Storage/Publisher/action.pm line 1992.