Comment 2 for bug 1115599

I did further testing on a 2.4.2 system where we are indeed able to receive line items that have been canceled. I tracked the return of this problem down to https://bugs.launchpad.net/evergreen/+bug/1115599. I should have read that bug report more closely when it was submitted since it clearly states that you will only be able to mark pending-order and on-order items as received.

After looking at the code from that branch, I thought that I could possibly address this issue by adding "cancelled" to the list of li_post_po_states, thereby allowing it to be one of the states that that are receivable. However, since the li_post_po_states also are part of the li_active_states, I would also be allowing selected canceled line items to be added to an invoice.

Is it problem allowing canceled line items to be added to an invoice? On the surface, the one potential problem I saw with allowing this action is that, when I did so through the PO "create invoice" option, the invoice defaults to receiving just 0 copies. If staff do not notice this default, I could see potential problems with the invoice.

Alternatively, I could create a totally new variable to identify the states that are receivable. However, I didn't know if there was a more elegant way to handle this.